From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107370 invoked by alias); 30 Sep 2018 20:31:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107241 invoked by uid 89); 30 Sep 2018 20:30:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:87efdci, merges X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.49.60) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 30 Sep 2018 20:30:52 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway23.websitewelcome.com (Postfix) with ESMTP id BAEEC5A4D for ; Sun, 30 Sep 2018 15:30:50 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 6iMcgWnmORPoj6iMcgqmMn; Sun, 30 Sep 2018 15:30:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lgsCF6BrZPhsMkJHviOcwnYvKAwkOl2vHBGEGP4fylw=; b=HtfiMS54HYRSKHOUlGeEUYn1K8 604bIfbkNmYJWqrPA4R42WW5tNU0yGced2bjpipUFRDTPIatb36sIIS16ACw9elM1OxalPzUJXnXK UACAUclPbJlT0dD8IlIE8MSB6; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:57990 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g6iMc-001FBh-A7; Sun, 30 Sep 2018 15:30:50 -0500 From: Tom Tromey To: Eli Zaretskii Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: Upgrading readline References: <87efdcikqi.fsf@tromey.com> <83pnww5s1q.fsf@gnu.org> Date: Sun, 30 Sep 2018 20:31:00 -0000 In-Reply-To: <83pnww5s1q.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Sep 2018 16:53:05 +0300") Message-ID: <8736tqiv7q.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00946.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: Eli> The Readline version reportedly doesn't work with newer versions of Eli> Windows, so I think we should ask upstream Readline to use the newer Eli> code we have in GDB. I sent a note to bug-readline with the patch. >> I don't know the difference between __DJGPP__, __MSDOS__, and >> __GO32__ Eli> They are all equivalent, so I suggest to change them all to use Eli> __DJGPP__, unless there's some reason not to. >> the sources also check __MINGW32__, _WIN32, and __CYGWIN__ at >> places. Eli> These are unrelated to DOS/DJGPP/GO32, they are for MinGW builds and Eli> Cygwin builds. When I did the merge, these changes disappeared, so maybe I was misreading the diffs somehow. Or maybe I did the merge wrong, hard to say. What I did is make a new git repository and made a branch based on readline 6.2 patch 1 -- the gdb base revision. Then I copied the readline sources from the gdb repository on top of that and committed it. Finally, I did a git merge from readline 7.0 patch 5 and fixed up the conflicts. You can see the resulting repository here: https://github.com/tromey/gdb-readline/tree/gdb-readline Future merges can be done this way pretty easily, either by just recreating this process, or by cloning the repository and merging from the latest readline. readline 8 is in testing, so perhaps it would be good to try that to see if there are any new readline bugs affecting gdb. Tom