From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Upgrading readline
Date: Sat, 29 Sep 2018 13:53:00 -0000 [thread overview]
Message-ID: <83pnww5s1q.fsf@gnu.org> (raw)
In-Reply-To: <87efdcikqi.fsf@tromey.com> (message from Tom Tromey on Sat, 29 Sep 2018 05:52:37 -0600)
> From: Tom Tromey <tom@tromey.com>
> Date: Sat, 29 Sep 2018 05:52:37 -0600
>
> input.c, readline:
> +int
> +win32_isatty (int fd)
> +{
> + return (_isatty (fd) ? ((((long) (HANDLE) _get_osfhandle (fd)) & 3) == 3) : 0);
> +}
The Readline version reportedly doesn't work with newer versions of
Windows, so I think we should ask upstream Readline to use the newer
code we have in GDB.
> I don't know the difference between __DJGPP__, __MSDOS__, and
> __GO32__
They are all equivalent, so I suggest to change them all to use
__DJGPP__, unless there's some reason not to.
> the sources also check __MINGW32__, _WIN32, and __CYGWIN__ at
> places.
These are unrelated to DOS/DJGPP/GO32, they are for MinGW builds and
Cygwin builds.
Thanks for doing this.
next prev parent reply other threads:[~2018-09-29 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 11:53 Tom Tromey
2018-09-29 13:53 ` Eli Zaretskii [this message]
2018-09-30 20:31 ` Tom Tromey
2018-09-29 18:20 ` Pedro Alves
2018-10-18 22:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pnww5s1q.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox