From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112068 invoked by alias); 29 Sep 2018 13:53:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111706 invoked by uid 89); 29 Sep 2018 13:53:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=dos, DOS X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 29 Sep 2018 13:53:24 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6FgN-0002Kd-AS for gdb-patches@sourceware.org; Sat, 29 Sep 2018 09:53:23 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6FgM-0002KD-0Q; Sat, 29 Sep 2018 09:53:19 -0400 Received: from [176.228.60.248] (port=3083 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g6FgL-0000zE-JY; Sat, 29 Sep 2018 09:53:17 -0400 Date: Sat, 29 Sep 2018 13:53:00 -0000 Message-Id: <83pnww5s1q.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: gdb-patches@sourceware.org In-reply-to: <87efdcikqi.fsf@tromey.com> (message from Tom Tromey on Sat, 29 Sep 2018 05:52:37 -0600) Subject: Re: Upgrading readline References: <87efdcikqi.fsf@tromey.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00933.txt.bz2 > From: Tom Tromey > Date: Sat, 29 Sep 2018 05:52:37 -0600 > > input.c, readline: > +int > +win32_isatty (int fd) > +{ > + return (_isatty (fd) ? ((((long) (HANDLE) _get_osfhandle (fd)) & 3) == 3) : 0); > +} The Readline version reportedly doesn't work with newer versions of Windows, so I think we should ask upstream Readline to use the newer code we have in GDB. > I don't know the difference between __DJGPP__, __MSDOS__, and > __GO32__ They are all equivalent, so I suggest to change them all to use __DJGPP__, unless there's some reason not to. > the sources also check __MINGW32__, _WIN32, and __CYGWIN__ at > places. These are unrelated to DOS/DJGPP/GO32, they are for MinGW builds and Cygwin builds. Thanks for doing this.