Re: [PATCH] [pre-commit] Add tclint hook

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> I've just tried transferring settings to gdb/pyproject.toml (see patch
Tom> below), but that didn't work.  The docs say it's supposed to work
Tom> though, so some debugging is needed.

Thanks for trying it.  I guess maybe file an upstream bug report?

Anyway let's just go with your original patch.  We can always move the
config if/when tclint is fixed.

Approved-By: Tom Tromey <tom@tromey.com>

Tom> +# Used by tclfmt.  Doesn't support mixed TAB and spaces style we use. See
Tom> +# this tclint issue ( https://github.com/nmoroze/tclint/issues/109 ).
Tom> +indent = 4

Probably not the best spot to bring it up, but FWIW I never liked the 4
indent step for Tcl.  I always used 2 in my own code.  The reason is
that with 4 you end up with:

if {something complicated
    && requiring multiple lines} {
    then the code is indented just like the condition
}

as opposed to

if {something complicated
    && requiring multiple lines} {
  then the code is outdented just a little
}

Tom