Re: [PATCH] [pre-commit] Add tclint hook

[Tom de Vries <tdevries@suse.de>]

On 9/17/25 20:35, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> I've just tried transferring settings to gdb/pyproject.toml (see patch
> Tom> below), but that didn't work.  The docs say it's supposed to work
> Tom> though, so some debugging is needed.
> 
> Thanks for trying it.  I guess maybe file an upstream bug report?
I understand it now.  Using pyproject.toml works, provided you're 
running the command from the same directory.

So, in this case the pyproject.toml file is read, which prevents 
line-length warnings:
...
$ ( cd gdb; tclint testsuite/lib/gdb.exp )  | grep -c line-length
0
...

And in this case (which is what I do usually) not:
...
$ tclint gdb/testsuite/lib/gdb.exp  | grep -c line-length
17
...

I think that also might make it difficult to use tclint from pre-commit.

> Anyway let's just go with your original patch.  We can always move the
> config if/when tclint is fixed.
> 

Thanks, I'll push it.

> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom> +# Used by tclfmt.  Doesn't support mixed TAB and spaces style we use. See
> Tom> +# this tclint issue ( https://github.com/nmoroze/tclint/issues/109 ).
> Tom> +indent = 4
> 
> Probably not the best spot to bring it up, but FWIW I never liked the 4
> indent step for Tcl.  I always used 2 in my own code.  The reason is
> that with 4 you end up with:
> 
> if {something complicated
>      && requiring multiple lines} {
>      then the code is indented just like the condition
> }
> 
> as opposed to
> 
> if {something complicated
>      && requiring multiple lines} {
>    then the code is outdented just a little
> }

I got used to it, but I don't care too much one way or the other.  As 
long as I can use emacs with auto-indent, I'm fine :)

FWIW, atm we don't use tclfmt, but I thought it'd be useful to at least 
document current practice.

Thanks,
- Tom