From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id u2reGZz/ymjPOAgAWB0awg (envelope-from ) for ; Wed, 17 Sep 2025 14:36:12 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=kgF99TNk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4B6F31E0BA; Wed, 17 Sep 2025 14:36:12 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_SBL,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 68DE51E04C for ; Wed, 17 Sep 2025 14:36:11 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E52F53858C78 for ; Wed, 17 Sep 2025 18:36:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E52F53858C78 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=kgF99TNk Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 030D43858D26 for ; Wed, 17 Sep 2025 18:35:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 030D43858D26 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 030D43858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758134134; cv=none; b=S62AbllT27Lo03vIINaFzaa5s9ur8euW9t1tBbdrqoWO5nbUBvyndxCP1yWrgLbKLhYuuuCNX13+9p5UmxfLHRqSMrr5Xw1UiG2jnlgyMX5SqbO7yq59cnZcx2FqijYT68o8GerwwobTn4hwQlXomT+bGmNLkY1i/XgnsrCtwpo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758134134; c=relaxed/simple; bh=1J11Y1kjtfq11OktE4wlFnQ3gOOnzw+6kccnIQ3Ph/s=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=wNEc3ulx9urf+ZovnyuilNujvkQLezStmn8z9PlVEmI9lECnOGX1HMaNufwunkpmCY66d85vFspaqXzYIcgTcSQkqdzj5SLNdA5zK1cp5GSk/I2ag5gQ3+Q245KLzMmhmBqyiPIHyemqdMWRUzNNImw9icSzr2I5aYv4k6dZplk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 030D43858D26 Received: from eig-obgw-5003b.ext.cloudfilter.net ([10.0.29.155]) by cmsmtp with ESMTPS id yuZhuzsbBeNqiyx08ucceD; Wed, 17 Sep 2025 18:35:32 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id yx07uSnUurjTmyx08uDeKh; Wed, 17 Sep 2025 18:35:32 +0000 X-Authority-Analysis: v=2.4 cv=PfH/hjhd c=1 sm=1 tr=0 ts=68caff74 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=yJojWOMRYYMA:10 a=ItBw4LHWJt0A:10 a=NEAV23lmAAAA:8 a=zstS-IiYAAAA:8 a=Z8XjOhTYY0gSkHMCGV0A:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WTsDEeLQ67gNVIE6CbgRtIRCHxuAMHw7GEgs9hnea38=; b=kgF99TNkMkFmL5Ho+7cpE/MtuC 3iqhlSn7OOPiiiTOGUMC3uBZwChZz4lMCj1+SVjzeZoBofzhbZIgH64OyJ51UVjjOGZ4NaK5d1Yhx JLclODBN6qc7RUaP4I4o/T9HD; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:36242 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uyx07-00000002Jg2-2huT; Wed, 17 Sep 2025 12:35:31 -0600 From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] [pre-commit] Add tclint hook In-Reply-To: <5251058c-de2a-450a-bbbf-e420ae941047@suse.de> (Tom de Vries's message of "Wed, 17 Sep 2025 20:15:56 +0200") References: <20250915084105.23171-1-tdevries@suse.de> <87frcljdax.fsf@tromey.com> <5251058c-de2a-450a-bbbf-e420ae941047@suse.de> X-Attribution: Tom Date: Wed, 17 Sep 2025 12:35:31 -0600 Message-ID: <87348lj5ak.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1uyx07-00000002Jg2-2huT X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:36242 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfGqgA+luyi41h6hZ4OeFGUZPZWxMUm2OmipDBaIolkiQt2JKGwA935Bflt3lrDAFcHfnedtnSXl6ZE9hQ8GSgpYH2y27emVTysnRWIuucC84m+8fkhZ2 YoLxrdBjBheIqvDyVaMw/jT5x67mtUAVaX0mgIlwml+vXjrsubf6/a5GqmwaqVY/1ylnd7nwY88qgI7A11wPUuxaU60mFc8qp3I= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> I've just tried transferring settings to gdb/pyproject.toml (see patch Tom> below), but that didn't work. The docs say it's supposed to work Tom> though, so some debugging is needed. Thanks for trying it. I guess maybe file an upstream bug report? Anyway let's just go with your original patch. We can always move the config if/when tclint is fixed. Approved-By: Tom Tromey Tom> +# Used by tclfmt. Doesn't support mixed TAB and spaces style we use. See Tom> +# this tclint issue ( https://github.com/nmoroze/tclint/issues/109 ). Tom> +indent = 4 Probably not the best spot to bring it up, but FWIW I never liked the 4 indent step for Tcl. I always used 2 in my own code. The reason is that with 4 you end up with: if {something complicated && requiring multiple lines} { then the code is indented just like the condition } as opposed to if {something complicated && requiring multiple lines} { then the code is outdented just a little } Tom