Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: dje@google.com
Cc: Eli Zaretskii <eliz@gnu.org>,
	jan.kratochvil@redhat.com,        gdb-patches@sourceware.org
Subject: Re: [RFA, doc RFA] Implement $_memeq, $_streq, $_strlen
Date: Wed, 08 Aug 2012 18:00:00 -0000	[thread overview]
Message-ID: <871ujhgt7h.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20514.39220.59446.622043@ruffy2.mtv.corp.google.com>	(dje@google.com's message of "Wed, 8 Aug 2012 09:52:04 -0700")

>>>>> "Doug" == Douglas Evans <dje@google.com> writes:

Doug> +  ** $_memeq(buf1, buf2, length)
Doug> +  ** $_streq(str1, str2)

I don't really care, but I'm curious why you chose the eq forms instead
of the cmp forms.

[streq]
Doug> +    return a.string("iso-8859-1") == b.string("iso-8859-1")

I wonder whether this forces a constant string to inferior memory.
It would be nice to avoid that if possible.

The patch looks good, I think it is ok as-is.

Tom


  parent reply	other threads:[~2012-08-08 18:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07 21:37 dje
2012-08-08  7:11 ` Jan Kratochvil
2012-08-08 16:44 ` Eli Zaretskii
2012-08-08 16:52   ` dje
2012-08-08 17:15     ` Jan Kratochvil
2012-08-08 17:36     ` Eli Zaretskii
     [not found]       ` <CADPb22Q7_232vwcQxjDVrYA1ngWZ1DbChb6oSGArz7RzmHMVgw@mail.gmail.com>
2012-08-08 18:14         ` Eli Zaretskii
2012-08-08 18:00     ` Tom Tromey [this message]
     [not found]       ` <CADPb22SSM83g2tbBq2jpRj4SySwPS2Vqn-_5VxKYbvApV+VSMw@mail.gmail.com>
2012-08-10  4:14         ` dje
2012-08-10  6:39           ` Eli Zaretskii
2012-08-11  8:08           ` Regression for gdb.base/default.exp: show convenience [Re: [RFA, doc RFA] Implement $_memeq, $_streq, $_strlen] Jan Kratochvil
2012-08-11 17:46             ` dje
2012-08-11 17:54               ` Eli Zaretskii
2012-08-11 19:24               ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871ujhgt7h.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox