From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14155 invoked by alias); 8 Aug 2012 18:00:39 -0000 Received: (qmail 14138 invoked by uid 22791); 8 Aug 2012 18:00:37 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Aug 2012 18:00:21 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q78I0DnM019435 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 8 Aug 2012 14:00:15 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q78I024f029037 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 8 Aug 2012 14:00:07 -0400 From: Tom Tromey To: dje@google.com Cc: Eli Zaretskii , jan.kratochvil@redhat.com, gdb-patches@sourceware.org Subject: Re: [RFA, doc RFA] Implement $_memeq, $_streq, $_strlen References: <834nodfi6f.fsf@gnu.org> <20514.39220.59446.622043@ruffy2.mtv.corp.google.com> Date: Wed, 08 Aug 2012 18:00:00 -0000 In-Reply-To: <20514.39220.59446.622043@ruffy2.mtv.corp.google.com> (dje@google.com's message of "Wed, 8 Aug 2012 09:52:04 -0700") Message-ID: <871ujhgt7h.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00262.txt.bz2 >>>>> "Doug" == Douglas Evans writes: Doug> + ** $_memeq(buf1, buf2, length) Doug> + ** $_streq(str1, str2) I don't really care, but I'm curious why you chose the eq forms instead of the cmp forms. [streq] Doug> + return a.string("iso-8859-1") == b.string("iso-8859-1") I wonder whether this forces a constant string to inferior memory. It would be nice to avoid that if possible. The patch looks good, I think it is ok as-is. Tom