From: Eli Zaretskii <eliz@gnu.org>
To: dje@google.com
Cc: jan.kratochvil@redhat.com, gdb-patches@sourceware.org
Subject: Re: [RFA, doc RFA] Implement $_memeq, $_streq, $_strlen
Date: Wed, 08 Aug 2012 17:36:00 -0000 [thread overview]
Message-ID: <83zk65e16q.fsf@gnu.org> (raw)
In-Reply-To: <20514.39220.59446.622043@ruffy2.mtv.corp.google.com>
> Date: Wed, 8 Aug 2012 09:52:04 -0700
> Cc: gdb-patches@sourceware.org
> From: dje@google.com
>
> In response to Jan's strstr comment, I added $_regex.
Here I have a couple of comments:
> +@item $_regex(@var{str}, @var{regex})
> +@vindex $_regex@r{, convenience function}
> +Returns one if the string @var{str} matches the regular expression
> +@var{regex}. Otherwise it returns zero.
> +The syntax of the regular expression is that specified by @code{Python}'s
> +regular expression support.
I would suggest to say here that 'str' and 'regex' are both C strings,
as you say for $_strlen etc. Otherwise, the reference to Python could
fool the reader into thinking they should be Python strings.
Btw, what is the technical reason we require Python for these
functions?
Finally, I think it's better to use @findex instead of @vindex
(since these are functions). Sorry I missed that earlier.
Thanks.
next prev parent reply other threads:[~2012-08-08 17:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 21:37 dje
2012-08-08 7:11 ` Jan Kratochvil
2012-08-08 16:44 ` Eli Zaretskii
2012-08-08 16:52 ` dje
2012-08-08 17:15 ` Jan Kratochvil
2012-08-08 17:36 ` Eli Zaretskii [this message]
[not found] ` <CADPb22Q7_232vwcQxjDVrYA1ngWZ1DbChb6oSGArz7RzmHMVgw@mail.gmail.com>
2012-08-08 18:14 ` Eli Zaretskii
2012-08-08 18:00 ` Tom Tromey
[not found] ` <CADPb22SSM83g2tbBq2jpRj4SySwPS2Vqn-_5VxKYbvApV+VSMw@mail.gmail.com>
2012-08-10 4:14 ` dje
2012-08-10 6:39 ` Eli Zaretskii
2012-08-11 8:08 ` Regression for gdb.base/default.exp: show convenience [Re: [RFA, doc RFA] Implement $_memeq, $_streq, $_strlen] Jan Kratochvil
2012-08-11 17:46 ` dje
2012-08-11 17:54 ` Eli Zaretskii
2012-08-11 19:24 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zk65e16q.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox