From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93629-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1733 invoked by alias); 8 Aug 2012 17:36:13 -0000
Received: (qmail 1514 invoked by uid 22791); 8 Aug 2012 17:36:11 -0000
X-SWARE-Spam-Status: No, hits=-4.3 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Aug 2012 17:35:56 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0M8G0010064LJR00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Wed, 08 Aug 2012 20:35:55 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M8G001CY67U0T80@a-mtaout20.012.net.il>; Wed, 08 Aug 2012 20:35:55 +0300 (IDT)
Date: Wed, 08 Aug 2012 17:36:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA, doc RFA] Implement $_memeq, $_streq, $_strlen
In-reply-to: <20514.39220.59446.622043@ruffy2.mtv.corp.google.com>
To: dje@google.com
Cc: jan.kratochvil@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83zk65e16q.fsf@gnu.org>
References: <yjt27gtapeo0.fsf@ruffy.mtv.corp.google.com> <834nodfi6f.fsf@gnu.org> <20514.39220.59446.622043@ruffy2.mtv.corp.google.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00258.txt.bz2

> Date: Wed, 8 Aug 2012 09:52:04 -0700
> Cc: gdb-patches@sourceware.org
> From: dje@google.com
> 
> In response to Jan's strstr comment, I added $_regex.

Here I have a couple of comments:

> +@item $_regex(@var{str}, @var{regex})
> +@vindex $_regex@r{, convenience function}
> +Returns one if the string @var{str} matches the regular expression
> +@var{regex}.  Otherwise it returns zero.
> +The syntax of the regular expression is that specified by @code{Python}'s
> +regular expression support.

I would suggest to say here that 'str' and 'regex' are both C strings,
as you say for $_strlen etc.  Otherwise, the reference to Python could
fool the reader into thinking they should be Python strings.

Btw, what is the technical reason we require Python for these
functions?

Finally, I think it's better to use @findex instead of @vindex
(since these are functions).  Sorry I missed that earlier.

Thanks.