From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Doug Evans <dje@google.com>,
gdb-patches@sourceware.org, ibobyr@google.com,
Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] rust/25535 Apply embedded offset to enum variant calculation
Date: Wed, 12 Feb 2020 07:54:00 -0000 [thread overview]
Message-ID: <871rr0b5pv.fsf@tromey.com> (raw)
In-Reply-To: <8bed0bb2-50ae-07ac-5176-8d7e1fc443c8@simark.ca> (Simon Marchi's message of "Wed, 12 Feb 2020 00:13:54 -0500")
>> gdb/ChangeLog
>> PR rust/25535
>> * rust-lang.c (rust_print_enum): Apply embedded_offset to
>> rust_enum_variant calculation.
>>
>> gdb/testsuite/ChangeLog
>> PR rust/25535
>> * gdb.rust/simple.exp: Add test.
>> * gdb.rust/simple.rs: Add test.
Simon> Hi Doug,
Simon> Tom has this big series that gets rid of the val_print API (and therefore embedded_offset),
Simon> which I think was on its way in. See this patch here in particular:
Simon> https://sourceware.org/ml/gdb-patches/2019-12/msg00288.html
Simon> Could you check if that fixes the bug? Of course, the test you add would still be relevant.
I think it's fine to land this now.
I'll try to rebase the val_print thing soon. I've kind of been breaking
things a lot so I've been putting it off a little.
Tom
next prev parent reply other threads:[~2020-02-12 7:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 1:01 Doug Evans via gdb-patches
2020-02-12 1:09 ` Doug Evans via gdb-patches
2020-02-12 5:13 ` Simon Marchi
2020-02-12 7:54 ` Tom Tromey [this message]
2020-02-12 14:12 ` Simon Marchi
2020-02-19 20:58 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rr0b5pv.fsf@tromey.com \
--to=tom@tromey.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=ibobyr@google.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox