From: Simon Marchi <simark@simark.ca>
To: Doug Evans <dje@google.com>, gdb-patches@sourceware.org
Cc: ibobyr@google.com, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] rust/25535 Apply embedded offset to enum variant calculation
Date: Wed, 12 Feb 2020 05:13:00 -0000 [thread overview]
Message-ID: <8bed0bb2-50ae-07ac-5176-8d7e1fc443c8@simark.ca> (raw)
In-Reply-To: <000000000000fb79ae059e568398@google.com>
On 2020-02-11 8:01 p.m., Doug Evans via gdb-patches wrote:
> Hopefully straightforward (and I didn't miss anything ...).
>
> gdb/ChangeLog
> PR rust/25535
> * rust-lang.c (rust_print_enum): Apply embedded_offset to
> rust_enum_variant calculation.
>
> gdb/testsuite/ChangeLog
> PR rust/25535
> * gdb.rust/simple.exp: Add test.
> * gdb.rust/simple.rs: Add test.
Hi Doug,
Tom has this big series that gets rid of the val_print API (and therefore embedded_offset),
which I think was on its way in. See this patch here in particular:
https://sourceware.org/ml/gdb-patches/2019-12/msg00288.html
Could you check if that fixes the bug? Of course, the test you add would still be relevant.
Simon
next prev parent reply other threads:[~2020-02-12 5:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 1:01 Doug Evans via gdb-patches
2020-02-12 1:09 ` Doug Evans via gdb-patches
2020-02-12 5:13 ` Simon Marchi [this message]
2020-02-12 7:54 ` Tom Tromey
2020-02-12 14:12 ` Simon Marchi
2020-02-19 20:58 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bed0bb2-50ae-07ac-5176-8d7e1fc443c8@simark.ca \
--to=simark@simark.ca \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=ibobyr@google.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox