From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56827 invoked by alias); 12 Feb 2020 07:54:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56819 invoked by uid 89); 12 Feb 2020 07:54:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2020 07:54:55 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway33.websitewelcome.com (Postfix) with ESMTP id F30143D9A7D for ; Wed, 12 Feb 2020 01:54:53 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1mrFjlsmvRP4z1mrFjDdHR; Wed, 12 Feb 2020 01:54:53 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=N4Sq7Vqh6dEObugsWpnPnQGBAqCDvEO3BUiof3gQpws=; b=eSJGpwDKm0xZHFVrvky9k0zAXp rrlId1lddyidU6ufpkxAtLpSQKAIPeXXAe2SSJ7eoXiVSYNyBN0tY9a4tGlcCp2cdUSDvlW4PZVzY VzVDJdt5VGdXr5x+Ib/k9g++/; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:56524 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j1mrF-003nSs-Jj; Wed, 12 Feb 2020 00:54:53 -0700 From: Tom Tromey To: Simon Marchi Cc: Doug Evans , gdb-patches@sourceware.org, ibobyr@google.com, Tom Tromey Subject: Re: [PATCH] rust/25535 Apply embedded offset to enum variant calculation References: <000000000000fb79ae059e568398@google.com> <8bed0bb2-50ae-07ac-5176-8d7e1fc443c8@simark.ca> Date: Wed, 12 Feb 2020 07:54:00 -0000 In-Reply-To: <8bed0bb2-50ae-07ac-5176-8d7e1fc443c8@simark.ca> (Simon Marchi's message of "Wed, 12 Feb 2020 00:13:54 -0500") Message-ID: <871rr0b5pv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00445.txt.bz2 >> gdb/ChangeLog >> PR rust/25535 >> * rust-lang.c (rust_print_enum): Apply embedded_offset to >> rust_enum_variant calculation. >> >> gdb/testsuite/ChangeLog >> PR rust/25535 >> * gdb.rust/simple.exp: Add test. >> * gdb.rust/simple.rs: Add test. Simon> Hi Doug, Simon> Tom has this big series that gets rid of the val_print API (and therefore embedded_offset), Simon> which I think was on its way in. See this patch here in particular: Simon> https://sourceware.org/ml/gdb-patches/2019-12/msg00288.html Simon> Could you check if that fixes the bug? Of course, the test you add would still be relevant. I think it's fine to land this now. I'll try to rebase the val_print thing soon. I've kind of been breaking things a lot so I've been putting it off a little. Tom