From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] gdb/objfiles: use filtered_iterator as objfile::section_iterator
Date: Fri, 29 Aug 2025 07:42:29 -0600 [thread overview]
Message-ID: <871pouutve.fsf@tromey.com> (raw)
In-Reply-To: <20250828151100.84594-3-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 28 Aug 2025 11:10:51 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
Simon> objfile::section_iterator looks like a good candidate to be implemented
Simon> with filtered_iterator. Following the enhancements to filtered_iterator
Simon> in the previous patch, it's pretty straighforward.
Simon> I removed the non-const version of objfile::sections, because it didn't
Simon> seem useful to have the two methods returning the exact same type and
Simon> value. Having just the const version achieves the same thing.
I would have thought the const one would return a const iterator and not
allow modifications to the underlying objects.
Anyway if it didn't then that's just some pre-existing bug, probably not
too important.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2025-08-29 13:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 15:10 [PATCH 1/3] gdb/objfiles: make objfile::sections yield references Simon Marchi
2025-08-28 15:10 ` [PATCH 2/3] gdbsupport: make filtered_iterator work with pointers Simon Marchi
2025-08-29 13:40 ` Tom Tromey
2025-08-29 16:00 ` Simon Marchi
2025-08-29 17:39 ` Tom Tromey
2025-08-29 20:11 ` Simon Marchi
2025-09-03 2:01 ` Tom Tromey
2025-08-29 17:59 ` Simon Marchi
2025-08-29 18:19 ` Tom Tromey
2025-08-28 15:10 ` [PATCH 3/3] gdb/objfiles: use filtered_iterator as objfile::section_iterator Simon Marchi
2025-08-29 13:42 ` Tom Tromey [this message]
2025-08-29 16:06 ` Simon Marchi
2025-08-29 20:22 ` Simon Marchi
2025-08-29 13:34 ` [PATCH 1/3] gdb/objfiles: make objfile::sections yield references Tom Tromey
2025-08-29 15:47 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871pouutve.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox