From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SxknEWmusWiNUg8AWB0awg (envelope-from ) for ; Fri, 29 Aug 2025 09:43:05 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=NKgNRjbb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 33BDA1E043; Fri, 29 Aug 2025 09:43:05 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9F82B1E043 for ; Fri, 29 Aug 2025 09:43:04 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 39F023858427 for ; Fri, 29 Aug 2025 13:43:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 39F023858427 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=NKgNRjbb Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 8F88C3858C74 for ; Fri, 29 Aug 2025 13:42:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F88C3858C74 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8F88C3858C74 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756474954; cv=none; b=ersJ7DUsJEMRgSiCCK0cwMxN/hM7oylV2Kgqaj5/uKk6s9yf/ZYS6HwJyvqIjB9xaRLVEQFVufir9ZLIGHKKqvIcDEKE02A4Oh8N3hg8yHu8rtuwN+2BPlKwx1utyAkn1z7CSzyfmHh8RzoaBc+JR4uOrnAZt4bhlFyD59n0jMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756474954; c=relaxed/simple; bh=ZZQU+OcGZXtspgmTE63/Yvnni2sDKTTWhXacjsNXxwo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ORWCpN1p+a2fiMdy3CDDsvrtV6ZjpboEgmXkRiJRmPA8ty0Hu9b0/7UhXN6OShHY/h8C+jvET/fEZmv5nfN2qQuX7ZAZk1VV4n921WeQPXtYm/TgsIDJ/Sy2WTglxdFi1/Pzcno7IxiTVLLrwzszIUA0Mmomwy5axQC28/Hhla8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8F88C3858C74 Received: from eig-obgw-5007b.ext.cloudfilter.net ([10.0.29.167]) by cmsmtp with ESMTPS id rvtsuOjTCy3rHrzNBuBqVe; Fri, 29 Aug 2025 13:42:33 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id rzNAufUP4OhG0rzNBuL434; Fri, 29 Aug 2025 13:42:33 +0000 X-Authority-Analysis: v=2.4 cv=PIgP+eqC c=1 sm=1 tr=0 ts=68b1ae49 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=2OwXVqhp2XgA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=Dr-qutNsPa_Dm-h9ehAA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4Y3YJE9STU3kmY+ySSO3NomnZaW096Vq0njlMhUCl8E=; b=NKgNRjbbWsWfKTfViMu1K+8Ago 0ci1D533bNZqowHR1l2ePt0mg7oSilayPFHHAgmr9DeB/iFJLvIVFiktCimjVurA2+icbwOSklxV0 aPCLSTLsNv0aqtT+DLJCKukS9; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:54920 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1urzN9-00000000Oh1-3t6D; Fri, 29 Aug 2025 07:42:32 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] gdb/objfiles: use filtered_iterator as objfile::section_iterator In-Reply-To: <20250828151100.84594-3-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 28 Aug 2025 11:10:51 -0400") References: <20250828151100.84594-1-simon.marchi@efficios.com> <20250828151100.84594-3-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 29 Aug 2025 07:42:29 -0600 Message-ID: <871pouutve.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1urzN9-00000000Oh1-3t6D X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:54920 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfH5leunE3xHeRdvWOpObiVNYCJTELH+S6f96+OknftD8NNcnrq08HhSGIPKRKNgf89u7xR+oKTOfpn9dFEps4gpXkiVRAVdFrd+YhFj2MYY2k8M8yrQg X0ub9pXdk6as9kAycCn0aslSMaAOfGgsnHStSLCpSprDmQ2TGOwB4kLgTfoAAk3UDrkXThcIP/m+4tW8rbZGsUGu3XAk2EQLqQU= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> objfile::section_iterator looks like a good candidate to be implemented Simon> with filtered_iterator. Following the enhancements to filtered_iterator Simon> in the previous patch, it's pretty straighforward. Simon> I removed the non-const version of objfile::sections, because it didn't Simon> seem useful to have the two methods returning the exact same type and Simon> value. Having just the const version achieves the same thing. I would have thought the const one would return a const iterator and not allow modifications to the underlying objects. Anyway if it didn't then that's just some pre-existing bug, probably not too important. Approved-By: Tom Tromey Tom