From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove ui_out::do_field_fmt
Date: Tue, 20 Oct 2026 09:06:47 -0600 [thread overview]
Message-ID: <871p9k1ke0.fsf@tromey.com> (raw)
In-Reply-To: <20260917161611.3104728-1-tromey@adacore.com> (Tom Tromey's message of "Thu, 17 Sep 2026 10:16:11 -0600")
>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:
Tom> A user pointed out that certain MI output was not correctly quoted.
Tom> He tracked this down to mi_ui_out::do_field_fmt.
Tom> Looking into this, it seems to me that do_field_fmt is not needed at
Tom> all. Instead, ui_out can handle the formatting, and then delegate to
Tom> do_field_string.
Tom> This approach fixes the original bug, because the MI implementation of
Tom> do_field_string does perform the quoting.
Tom> This also slips in a small change to use checked_static_cast in
Tom> mi_ui_out::main_stream.
I'm checking this in.
Tom
prev parent reply other threads:[~2026-10-20 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 16:16 Tom Tromey
2026-09-21 9:29 ` Christian Walther
2026-10-20 15:06 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871p9k1ke0.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox