From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +eHwB6WD12pK0ToAWB0awg (envelope-from ) for ; Tue, 20 Oct 2026 11:07:17 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=GcdDDi8H; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0D4221E04D; Tue, 20 Oct 2026 11:07:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 34C901E04D for ; Tue, 20 Oct 2026 11:07:16 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E741D4BB5932 for ; Tue, 20 Oct 2026 15:07:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E741D4BB5932 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=GcdDDi8H Received: from mail-oo1-xc32.google.com (mail-oo1-xc32.google.com [IPv6:2607:f8b0:4864:20::c32]) by sourceware.org (Postfix) with ESMTPS id 81ACE4BAE7CC for ; Tue, 20 Oct 2026 15:06:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 81ACE4BAE7CC Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 81ACE4BAE7CC Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792508811; cv=none; b=OrlDDIbIp/UsKlrfsSPaI0YTTCg7q5ZoTHswXy71BB3bjWaHrat89ngWb8psmaVZbI2J/GmJLArMso6MW0IxMMCVVyuZLZvC/KBwvHXMKfkzScxR3MOUMMl2J91xdFdMtmJB5/bCbTMuxHH8FXB3SnF/kNuf/GfHvlEBuiwVxzM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792508811; c=relaxed/simple; bh=EM7UJXFbNVq4KAuxf9QJIk6+AFrY7Z0sy8CW+o4qGSk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=L2AHfTBcvXwxtJRpdNsshHgfmouyy4HwWJdd4+g0fbFAhBgXGj0HUKycYTElmQBf8A9/Wq1YLcrt4wJsaHOrBzuaJGc0I+UXRvTEIUFosUDCHYUbnxAkIkHJ+l3Tosnxl99JXw02GZFhpHSaT/rCHZngySh0JfwUDIZlFoF5tDc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=GcdDDi8H DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 81ACE4BAE7CC Received: by mail-oo1-xc32.google.com with SMTP id 006d021491bc7-6b8e2d8df4fso2283024eaf.1 for ; Tue, 20 Oct 2026 08:06:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1792508810; x=1793113610; darn=sourceware.org; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=+vOG8j6oihjhhKy8VHZMGZIySR85X32BVafjcG9qLqg=; b=GcdDDi8HbS/Sp4vD6W81p5gHH4mdhGf9/CnO+I8biIbI2iNoiShJFzyM7tOe6QS97k gc3eeF0aEaBWwn5iXzvuYtsk0122yrq8QxjcCr0rHsUsRuUi3/vR0jnEjTxbOSUGaWzg FN3etE3GsPm2tBgDt2YGS+aq6N5AQjwN50wR5mjhk2bPOQHe4sNB6lRvb+BgacgS+PD6 p+IWk64w7uWXmEc1A8+/yg0gQaEAUjAL/1cISxYJ3JImmzMnH9qrSE0iS3YGOuBZhZvS ixuiGWY+VgJKfIu9q0R+bSyMsMKiwcZ52mA9Gg3P9jZfxezJeFP0OmOg/65eUKkdeWU7 YS8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792508810; x=1793113610; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=+vOG8j6oihjhhKy8VHZMGZIySR85X32BVafjcG9qLqg=; b=qkq1Q5iapkgfYlQwmO2DVM4/pR03vnijCwRKy8Lf8TeTpCvgAaiUubk+OYtn+D7Csv NT3WKV60oG3YHANIXAhGsVReSIXSyB8vylEyusXynflIfrbmSxfqK2Zq66dBUou7K3JE YYBB52WZEsR3nrl+7k6KofAdSt5ZNzfn3Mp/ODPXVy+eguiScfIlP8dKHVR4dd4XAPba YgIXkReZ8Ju/irmLAy/smWtCnZd9VHahkoklbm+6xvSl0SSQkbXdEKhMmzBF5lImyHc3 p34xtdb3tIw6fd+QP5KO9DP6hyJD68w/RtsCoAXHH3bFTj5Tegdn0X5S0IM76bzD/OAy qsrg== X-Gm-Message-State: AFq9FYKZILfha8fqFLyr4Bkaq31sNtqVbc3uqKmpZcnLgnJwCthSyRQ+ qrHKhLaiUE6pkRGTaOSAR2wLVcWw3KTqNFuLRGruYf17qrly88QzZvRIZ2SnNA4XVHusQPLw6OQ 4bFx2Gg== X-Gm-Gg: AYBFou0Dt1qG5mOLkqXkC7lvT5TtgniVrS9av3Kz1yt5H1qmqYzc8AMJRDsgoKD3iUL FLY2vuJFee5Rzx+/xLzPa4RbldYpDoQ/t1yXVTdgJOHr+KZRfyXVTV2JRzZi6l068t85ENXWTd1 CR9K2Kr4Lq8Bh6INbnvQEmnPlb4CKfEJ8AW+EK9IATzMs81zEU4DGEW5hYtmuQyQ7tJygf0Fv8+ 1D+5wuaSKr1Q6wudTz5iRSms0STeOGfWR3ox3xSh+YBZClh5ykAYZrEveGFH3Stu8Jz0X+5+KGv DgVcSGO7EI0kEPLDkYaaDbJ3Z14ORT6e13KV/huExi2InNo06FmxXAan/2Dja3ACdXAXgWnzp4D lFsN902ICkTT0jxTxH1dOGHq9QgP+J8eX60lP8lXPTlM+hSgF1ZIxpU/xpnjIxl0NL6zBWLVVuL hAuQggWCcGxGXqSQxlqPg6IPL33QgMijWhbBerxwDJgi6jVMh0OAWVlKLaoBvtN7zgJd4oE9LBE Cv63cZ0eicRm8caSlsV X-Received: by 2002:a05:6820:2224:b0:6f7:c0ec:1a67 with SMTP id 006d021491bc7-70355c88770mr8068533eaf.21.1792508809310; Tue, 20 Oct 2026 08:06:49 -0700 (PDT) Received: from bapiya (97-122-110-129.hlrn.qwest.net. [97.122.110.129]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-70676f96ec7sm3688469eaf.4.2026.10.20.08.06.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2026 08:06:48 -0700 (PDT) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Remove ui_out::do_field_fmt In-Reply-To: <20260917161611.3104728-1-tromey@adacore.com> (Tom Tromey's message of "Thu, 17 Sep 2026 10:16:11 -0600") References: <20260917161611.3104728-1-tromey@adacore.com> X-Attribution: Tom Date: Tue, 20 Oct 2026 09:06:47 -0600 Message-ID: <871p9k1ke0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom Tromey writes: Tom> A user pointed out that certain MI output was not correctly quoted. Tom> He tracked this down to mi_ui_out::do_field_fmt. Tom> Looking into this, it seems to me that do_field_fmt is not needed at Tom> all. Instead, ui_out can handle the formatting, and then delegate to Tom> do_field_string. Tom> This approach fixes the original bug, because the MI implementation of Tom> do_field_string does perform the quoting. Tom> This also slips in a small change to use checked_static_cast in Tom> mi_ui_out::main_stream. I'm checking this in. Tom