From: Christian Walther <walther@indel.ch>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove ui_out::do_field_fmt
Date: Mon, 21 Sep 2026 11:29:27 +0200 [thread overview]
Message-ID: <1DFBCB6D-20C1-40DA-86B0-197151B94121@indel.ch> (raw)
In-Reply-To: <20260917161611.3104728-1-tromey@adacore.com>
On 17 Sep 2026, at 18:16, Tom Tromey <tromey@adacore.com> wrote:
> A user pointed out that certain MI output was not correctly quoted.
> He tracked this down to mi_ui_out::do_field_fmt.
>
> Looking into this, it seems to me that do_field_fmt is not needed at
> all. Instead, ui_out can handle the formatting, and then delegate to
> do_field_string.
>
> This approach fixes the original bug, because the MI implementation of
> do_field_string does perform the quoting.
>
> This also slips in a small change to use checked_static_cast in
> mi_ui_out::main_stream.
>
> Regression tested on x86-64 Fedora 43.
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34599
Looks good to me, as far as I can tell as an outsider, and does fix my issue. Thanks!
-Christian
prev parent reply other threads:[~2026-09-21 9:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 16:16 Tom Tromey
2026-09-21 9:29 ` Christian Walther [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1DFBCB6D-20C1-40DA-86B0-197151B94121@indel.ch \
--to=walther@indel.ch \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox