From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7DVrAjH5sGonaCsAWB0awg (envelope-from ) for ; Mon, 21 Sep 2026 05:30:25 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=indel.ch header.i=@indel.ch header.a=rsa-sha256 header.s=webland header.b=mpPp7TSh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D31371E051; Mon, 21 Sep 2026 05:30:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BCB311E033 for ; Mon, 21 Sep 2026 05:30:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D3DBA4BA2E26 for ; Mon, 21 Sep 2026 09:30:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D3DBA4BA2E26 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=indel.ch header.i=@indel.ch header.a=rsa-sha256 header.s=webland header.b=mpPp7TSh Received: from ms9.webland.ch (ms9.webland.ch [92.43.217.109]) by sourceware.org (Postfix) with ESMTPS id CB3144BA5436 for ; Mon, 21 Sep 2026 09:29:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB3144BA5436 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=indel.ch Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=indel.ch ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CB3144BA5436 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=92.43.217.109 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789982985; cv=none; b=sDAmlEiSkyXJUBvYKcJyza1F26Rt8Ta/IvDguOEQIqvHzUegXeSpFcTlBUdOHYTnfnTZdTMQhoJXhfPm5HX0DTjcHYy0z74RzYRGeEOf0kUFUXjqdkaJaDaHH5ETeoXyMZkEu1vTAV+1+LYIhbVJMUqgCbzrORaDT2dh9hADOg8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789982985; c=relaxed/simple; bh=2Ut/XlOaZF7yhVfQyK7Uev9PWpX40GFDBlPw0AV/Llw=; h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To; b=rTd4jMFPKH93Erc70IjZBWyrLyfZzgz8u3mcrbf4DNW9n0x/VfDop7Yo/rpScCia76Ov8RmN7qTlobuxHNcwLdJESN+tZP7gzcjdUV4niqULLGuXAKDGd69KiKqj3GXTGC+m4fF11bfpolfJXrp84cOPy+dtJqOjzZj8AQ/eoY4= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=indel.ch header.i=@indel.ch header.a=rsa-sha256 header.s=webland header.b=mpPp7TSh DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CB3144BA5436 DKIM-Signature: a=rsa-sha256; t=1789982980; x=1790587780; s=webland; d=indel.ch; c=relaxed/relaxed; v=1; bh=H5J0JCZPOkoTvqpnuHNIwCUxK317s51RxT6vXZ6lowo=; h=From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References; b=mpPp7TShVphdkO+1zHASf8ZNJkYub9Rrg2HoMfj+dXSYF9QB7gE8npyudqoC+muhAyRV4MAchzNkhXHCHw2nDmlLHVcIl5Vu9KcNPGl4hA9M8dfUt2YD5sV6RPeY7hV2XINJjr9J27aV6hExqNyf1J17Cno22NZjZ/l5jRD20nkGR7cyCOUO8P5zu4xmpxhiiS5L55YrR0CEr7W53ResmUWmTM3GezLDZNGa8BpE6rc3PtA+1TcLpAY/sAKtmP/zYrnRGzDPlMVC36OYrsgZRfxk2bow1xkxVNtG+NK4tMCsqol/oc49tnHE3/9+yQWj/DiNS6EbqOskwDKY6Qma4g== Received: from mail.indel.private ([46.126.221.40]) by ms9.webland.ch (12.3.0 build 2 x64) with ASMTP (SSL) id 01202609211129394064; Mon, 21 Sep 2026 11:29:39 +0200 Received: from localhost (localhost [127.0.0.1]) by mail.indel.private (Postfix) with ESMTP id 58DFB65646D0; Mon, 21 Sep 2026 11:29:38 +0200 (CEST) X-Virus-Scanned: amavisd-new at indel.ch Received: from mail.indel.private ([127.0.0.1]) by localhost (mail.indel.private [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H2O30AMc7yQP; Mon, 21 Sep 2026 11:29:37 +0200 (CEST) Received: from smtpclient.apple (unknown [192.168.1.28]) by mail.indel.private (Postfix) with ESMTP id 78CCC65646C3; Mon, 21 Sep 2026 11:29:37 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.8\)) Subject: Re: [PATCH] Remove ui_out::do_field_fmt From: Christian Walther In-Reply-To: <20260917161611.3104728-1-tromey@adacore.com> Date: Mon, 21 Sep 2026 11:29:27 +0200 Cc: gdb-patches@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: <1DFBCB6D-20C1-40DA-86B0-197151B94121@indel.ch> References: <20260917161611.3104728-1-tromey@adacore.com> To: Tom Tromey X-Mailer: Apple Mail (2.3826.700.81.1.8) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 17 Sep 2026, at 18:16, Tom Tromey wrote: > A user pointed out that certain MI output was not correctly quoted. > He tracked this down to mi_ui_out::do_field_fmt. >=20 > Looking into this, it seems to me that do_field_fmt is not needed at > all. Instead, ui_out can handle the formatting, and then delegate to > do_field_string. >=20 > This approach fixes the original bug, because the MI implementation of > do_field_string does perform the quoting. >=20 > This also slips in a small change to use checked_static_cast in > mi_ui_out::main_stream. >=20 > Regression tested on x86-64 Fedora 43. >=20 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D34599 Looks good to me, as far as I can tell as an outsider, and does fix my = issue. Thanks! -Christian