Re: [PATCH v2 3/7] Implement breakpoint_from_kind for supported architectures in GDBServer.

[Yao Qi <qiyaoltc@gmail.com>]

Antoine Tremblay <antoine.tremblay@ericsson.com> writes:

There is no changelog entry.

> +/* Implementation of linux_target_ops method "breakpoint_from_kind".  */
> +
> +static const unsigned char *
> +aarch64_breakpoint_from_kind (int *kind)
> +{
> +    return (const unsigned char *) &aarch64_breakpoint;

Indentation looks odd, and do we really need the cast?

Note that this function is correct because we restrict the usage of Z0
packet.  Z0 packet is only used with non-extended protocol and inferior
is 64bit.  See aarch64_supports_z_point_type.  Once we remove the
restriction, we need to update this function to return different
breakpoint instructions (aarch64, arm, thumb, and thumb2) according to
*KIND and other information.

Otherwise, patch is OK to me.

-- 
Yao (齐尧)