Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: <gdb-patches@sourceware.org>
Cc: Antoine Tremblay <antoine.tremblay@ericsson.com>
Subject: [PATCH v2 2/7] Add breakpoint_from_kind target_ops for software breakpoints in GDBServer.
Date: Mon, 05 Oct 2015 16:44:00 -0000	[thread overview]
Message-ID: <1444063455-31558-3-git-send-email-antoine.tremblay@ericsson.com> (raw)
In-Reply-To: <1444063455-31558-1-git-send-email-antoine.tremblay@ericsson.com>

This patch is in preparation for software breakpoints on ARM in
GDBServer.

This patch introduces a new target_ops and linux_target_ops called
breakpoint_from_kind that will be used to ask the target for the right
breakpoint for a kind as set in a Z0 packet.

No regressions, tested on ubuntu 14.04 ARMv7 and x86.
With gdbserver-{native,extended} / { -marm -mthumb }

gdb/gdbserver/ChangeLog:
	* linux-low.c (linux_breakpoint_from_kind): New function.
	(struct target_ops) <breakpoint_from_kind>: Initialize field.
	* linux-low.h (struct linux_target_ops)
	<breakpoint_from_kind>: New field.
	* target.h (struct target_ops) <breakpoint_from_kind>: New field.
---
 gdb/gdbserver/linux-low.c | 10 ++++++++++
 gdb/gdbserver/linux-low.h |  4 ++++
 gdb/gdbserver/target.h    |  4 ++++
 3 files changed, 18 insertions(+)

diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
index dc16fe0..5aa2b1d 100644
--- a/gdb/gdbserver/linux-low.c
+++ b/gdb/gdbserver/linux-low.c
@@ -5965,6 +5965,15 @@ linux_supports_range_stepping (void)
   return (*the_low_target.supports_range_stepping) ();
 }
 
+static const unsigned char*
+linux_breakpoint_from_kind (int *kind)
+{
+  if (*the_low_target.breakpoint_from_kind != NULL)
+    return (*the_low_target.breakpoint_from_kind) (kind);
+  else
+    return NULL;
+}
+
 /* Enumerate spufs IDs for process PID.  */
 static int
 spu_enumerate_spu_ids (long pid, unsigned char *buf, CORE_ADDR offset, int len)
@@ -7040,6 +7049,7 @@ static struct target_ops linux_target_ops = {
   linux_mntns_unlink,
   linux_mntns_readlink,
   linux_breakpoint_from_pc,
+  linux_breakpoint_from_kind
 };
 
 static void
diff --git a/gdb/gdbserver/linux-low.h b/gdb/gdbserver/linux-low.h
index a9964ac..cc19b88 100644
--- a/gdb/gdbserver/linux-low.h
+++ b/gdb/gdbserver/linux-low.h
@@ -227,6 +227,10 @@ struct linux_target_ops
 
   /* Returns true if the low target supports range stepping.  */
   int (*supports_range_stepping) (void);
+
+  /* Returns the proper breakpoint from size, the kind can have target
+     specific meaning like the z0 kind parameter */
+  const unsigned char *(*breakpoint_from_kind) (int *kind);
 };
 
 extern struct linux_target_ops the_low_target;
diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
index 603819e..74fb36d 100644
--- a/gdb/gdbserver/target.h
+++ b/gdb/gdbserver/target.h
@@ -446,6 +446,10 @@ struct target_ops
      can be NULL, the default breakpoint for the target should be returned in
      this case.  */
   const unsigned char *(*breakpoint_from_pc) (CORE_ADDR *pcptr, int *lenptr);
+
+  /* Returns a breakpoint from a kind, a kind is a length can have target
+     specific meaning like the z0 kind parameter.  */
+  const unsigned char *(*breakpoint_from_kind) (int *kind);
 };
 
 extern struct target_ops *the_target;
-- 
1.9.1


  parent reply	other threads:[~2015-10-05 16:44 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05 16:44 [PATCH v2 0/7] Software breakpoints support for ARM linux " Antoine Tremblay
2015-10-05 16:44 ` [PATCH v2 5/7] Implement breakpoint_from_pc for ARM " Antoine Tremblay
2015-10-15 16:07   ` Pedro Alves
2015-10-15 18:06     ` Antoine Tremblay
2015-10-05 16:44 ` [PATCH v2 7/7] Support software breakpoints for ARM linux " Antoine Tremblay
2015-10-05 17:00   ` Eli Zaretskii
2015-10-15 16:07   ` Pedro Alves
2015-10-15 18:24     ` Antoine Tremblay
2015-10-15 18:33       ` Pedro Alves
2015-10-15 18:59         ` Antoine Tremblay
2015-10-16  9:33     ` Yao Qi
2015-10-16 12:11       ` Pedro Alves
2015-10-16 12:24   ` Yao Qi
2015-10-16 12:21     ` Yao Qi
2015-10-05 16:44 ` [PATCH v2 1/7] Add breakpoint_from_pc target_ops for software breakpoints " Antoine Tremblay
2015-10-15  8:27   ` Yao Qi
2015-10-15 15:33   ` Pedro Alves
2015-10-15 15:58     ` Antoine Tremblay
2015-10-15 17:05       ` Antoine Tremblay
2015-10-05 16:44 ` [PATCH v2 6/7] Refactor the breakpoint definitions in linux-arm-low.c Antoine Tremblay
2015-10-15 16:07   ` Pedro Alves
2015-10-16 12:14     ` Yao Qi
2015-10-05 16:44 ` [PATCH v2 4/7] Support breakpoint kinds for software breakpoints in GDBServer Antoine Tremblay
2015-10-15 15:51   ` Pedro Alves
2015-10-15 18:02     ` Antoine Tremblay
2015-10-16 16:06       ` Pedro Alves
2015-10-16 18:08         ` Antoine Tremblay
2015-10-16 19:04           ` Pedro Alves
2015-10-16 19:23             ` Antoine Tremblay
2015-10-16 19:44               ` Antoine Tremblay
2015-10-16 19:48                 ` Antoine Tremblay
2015-10-19  9:35                 ` Pedro Alves
2015-10-19 11:48                   ` Antoine Tremblay
2015-10-05 16:44 ` [PATCH v2 3/7] Implement breakpoint_from_kind for supported architectures " Antoine Tremblay
2015-10-15  9:19   ` Yao Qi
2015-10-15 10:57     ` Antoine Tremblay
2015-10-15 17:13       ` Antoine Tremblay
2015-10-05 16:44 ` Antoine Tremblay [this message]
2015-10-15  9:04   ` [PATCH v2 2/7] Add breakpoint_from_kind target_ops for software breakpoints " Yao Qi
2015-10-15 10:50     ` Antoine Tremblay
2015-10-15  9:10   ` Yao Qi
2015-10-15 10:37     ` Antoine Tremblay
2015-10-15 15:34   ` Pedro Alves
2015-10-15 17:07     ` Antoine Tremblay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444063455-31558-3-git-send-email-antoine.tremblay@ericsson.com \
    --to=antoine.tremblay@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox