From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124858 invoked by alias); 15 Oct 2015 09:19:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124840 invoked by uid 89); 15 Oct 2015 09:19:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f49.google.com Received: from mail-pa0-f49.google.com (HELO mail-pa0-f49.google.com) (209.85.220.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 15 Oct 2015 09:19:31 +0000 Received: by payp3 with SMTP id p3so34627376pay.1 for ; Thu, 15 Oct 2015 02:19:29 -0700 (PDT) X-Received: by 10.66.235.42 with SMTP id uj10mr9068153pac.32.1444900769452; Thu, 15 Oct 2015 02:19:29 -0700 (PDT) Received: from E107787-LIN (gcc2-power8.osuosl.org. [140.211.9.43]) by smtp.gmail.com with ESMTPSA id iu2sm11800791pbd.16.2015.10.15.02.19.27 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 15 Oct 2015 02:19:29 -0700 (PDT) From: Yao Qi To: Antoine Tremblay Cc: Subject: Re: [PATCH v2 3/7] Implement breakpoint_from_kind for supported architectures in GDBServer. References: <1444063455-31558-1-git-send-email-antoine.tremblay@ericsson.com> <1444063455-31558-4-git-send-email-antoine.tremblay@ericsson.com> Date: Thu, 15 Oct 2015 09:19:00 -0000 In-Reply-To: <1444063455-31558-4-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Mon, 5 Oct 2015 12:44:11 -0400") Message-ID: <86y4f432w2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00239.txt.bz2 Antoine Tremblay writes: There is no changelog entry. > +/* Implementation of linux_target_ops method "breakpoint_from_kind". */ > + > +static const unsigned char * > +aarch64_breakpoint_from_kind (int *kind) > +{ > + return (const unsigned char *) &aarch64_breakpoint; Indentation looks odd, and do we really need the cast? Note that this function is correct because we restrict the usage of Z0 packet. Z0 packet is only used with non-extended protocol and inferior is 64bit. See aarch64_supports_z_point_type. Once we remove the restriction, we need to update this function to return different breakpoint instructions (aarch64, arm, thumb, and thumb2) according to *KIND and other information. Otherwise, patch is OK to me. --=20 Yao (=E9=BD=90=E5=B0=A7)