From: Yao Qi <qiyaoltc@gmail.com>
To: "Wiederhake\, Tim" <tim.wiederhake@intel.com>
Cc: "Jose E. Marchesi" <jose.marchesi@oracle.com>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: MemoryView missing from Python 2.4 and 2.6
Date: Fri, 03 Mar 2017 10:21:00 -0000 [thread overview]
Message-ID: <86y3wmpsng.fsf@gmail.com> (raw)
In-Reply-To: <9676A094AF46E14E8265E7A3F4CCE9AF941DE1@irsmsx105.ger.corp.intel.com> (Tim Wiederhake's message of "Tue, 28 Feb 2017 10:53:17 +0000")
"Wiederhake, Tim" <tim.wiederhake@intel.com> writes:
> This changes the return type of "gdb.BtraceInstruction.data ()" from
> "memoryview" to "buffer" on Python 2.7 and below, similar to what
> "gdb.Inferior.read_memory ()" does.
The change looks reasonable to me. Do we need to update test case?
In py-inferior.exp, we have
gdb_py_test_silent_cmd "python str = gdb.inferiors()\[0\].read_memory (addr, 5); print(str)" \
"read str contents" 1
if { $gdb_py_is_py3k == 0 } {
gdb_py_test_silent_cmd "python a = 'a'" "" 0
} else {
gdb_py_test_silent_cmd "python a = bytes('a', 'ascii')" "" 0
}
I assume we need something similar here.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-03-03 10:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 16:48 Jose E. Marchesi
2017-02-23 17:06 ` Jose E. Marchesi
2017-02-23 22:59 ` Yao Qi
2017-02-24 10:37 ` Wiederhake, Tim
2017-02-24 16:06 ` Yao Qi
2017-02-24 16:14 ` Paul.Koning
2017-02-28 10:53 ` Wiederhake, Tim
2017-02-28 12:51 ` Jose E. Marchesi
2017-03-07 0:21 ` Joel Brobecker
2017-03-07 13:38 ` Wiederhake, Tim
2017-03-07 15:27 ` Joel Brobecker
2017-03-03 10:21 ` Yao Qi [this message]
2017-03-06 8:56 ` Wiederhake, Tim
2017-03-07 10:32 ` Yao Qi
2017-03-07 17:18 ` Wiederhake, Tim
2017-03-17 15:59 ` Yao Qi
2017-03-17 16:39 ` Jose E. Marchesi
2017-03-20 9:04 ` Yao Qi
2017-03-20 22:44 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86y3wmpsng.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=jose.marchesi@oracle.com \
--cc=tim.wiederhake@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox