From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94357 invoked by alias); 3 Mar 2017 10:21:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94316 invoked by uid 89); 3 Mar 2017 10:21:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=2.7 X-HELO: mail-wm0-f54.google.com Received: from mail-wm0-f54.google.com (HELO mail-wm0-f54.google.com) (74.125.82.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Mar 2017 10:21:54 +0000 Received: by mail-wm0-f54.google.com with SMTP id n11so11660676wma.0 for ; Fri, 03 Mar 2017 02:21:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=zwFkGlCZHjfNJ5n3eElIkHcw+fDblQ6veJjjObL0bl4=; b=d8UPz33Tv17p+ofnzrbBwvKX67djCBntcmLeZ7IEr63gpIyQGVILsqG7IVI/qG4NrK RBqoNVhf9iYWqEE7ZzqhHvwF++Zi93Ja7//AT4mUocj7q7tq+27S3thF9CgFh4D1ZdKZ G0hmabUMVZsu3+v5P5cfup01Sh24/+fwnUpzWVRAJHqwxurFTm2icxaZt9NvXm+LiL6D fQPFmwAlfWp5Oaws0c9P1qcM4I+YLhQ1q83FaXIXIW3I6EdFJgQ1gG4falwDJM1m2c77 ZzTdPiXSISpOFRzc3jIncHXmcARtC6DTRtzSqfIfoyH2XsvHZ/AWiHRP/MdcwReARRSV 2XiQ== X-Gm-Message-State: AMke39lAG0vPptiOU2myLFboTvxPW8CIAClWK7F4A/URLUWHxcwNIgxMb8ZR/2iv3EOV2g== X-Received: by 10.28.141.16 with SMTP id p16mr1841523wmd.42.1488536512534; Fri, 03 Mar 2017 02:21:52 -0800 (PST) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id b58sm14741145wra.47.2017.03.03.02.21.51 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 03 Mar 2017 02:21:51 -0800 (PST) From: Yao Qi To: "Wiederhake\, Tim" Cc: "Jose E. Marchesi" , "gdb-patches\@sourceware.org" Subject: Re: MemoryView missing from Python 2.4 and 2.6 References: <87o9xsx38r.fsf@oracle.com> <20170223225946.snir4ab6twc7vo7n@localhost> <9676A094AF46E14E8265E7A3F4CCE9AF9417D1@irsmsx105.ger.corp.intel.com> <86h93j7evn.fsf@gmail.com> <9676A094AF46E14E8265E7A3F4CCE9AF941DE1@irsmsx105.ger.corp.intel.com> Date: Fri, 03 Mar 2017 10:21:00 -0000 In-Reply-To: <9676A094AF46E14E8265E7A3F4CCE9AF941DE1@irsmsx105.ger.corp.intel.com> (Tim Wiederhake's message of "Tue, 28 Feb 2017 10:53:17 +0000") Message-ID: <86y3wmpsng.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00022.txt.bz2 "Wiederhake, Tim" writes: > This changes the return type of "gdb.BtraceInstruction.data ()" from > "memoryview" to "buffer" on Python 2.7 and below, similar to what > "gdb.Inferior.read_memory ()" does. The change looks reasonable to me. Do we need to update test case? In py-inferior.exp, we have gdb_py_test_silent_cmd "python str =3D gdb.inferiors()\[0\].read_memory (ad= dr, 5); print(str)" \ "read str contents" 1 if { $gdb_py_is_py3k =3D=3D 0 } { gdb_py_test_silent_cmd "python a =3D 'a'" "" 0 } else { gdb_py_test_silent_cmd "python a =3D bytes('a', 'ascii')" "" 0 } I assume we need something similar here. --=20 Yao (=E9=BD=90=E5=B0=A7)