From: Yao Qi <qiyaoltc@gmail.com>
To: Tim Wiederhake <tim.wiederhake@intel.com>
Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com,
brobecker@adacore.com
Subject: Re: [PATCH v2 5/8] Python: Introduce gdb.RecordGap class
Date: Fri, 21 Apr 2017 14:50:00 -0000 [thread overview]
Message-ID: <86y3utzufy.fsf@gmail.com> (raw)
In-Reply-To: <1492771786-26372-6-git-send-email-tim.wiederhake@intel.com> (Tim Wiederhake's message of "Fri, 21 Apr 2017 12:49:43 +0200")
Tim Wiederhake <tim.wiederhake@intel.com> writes:
> As discussed here: https://sourceware.org/ml/gdb-patches/2017-04/msg00157.html
>
> A gap is not an instruction and it should not pretend to be one.
Hi Tim,
Patch is good to me, a comment on commit log. Could you extract the
discussion summary in the url into the commit log? so people can read
them in git log easily.
--
Yao (齐尧)
prev parent reply other threads:[~2017-04-21 14:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 10:50 [PATCH v2 0/8] Python bindings for GDB record Tim Wiederhake
2017-04-21 10:50 ` [PATCH v2 7/8] Python: Move and rename gdb.BtraceFunction Tim Wiederhake
2017-04-21 12:22 ` Eli Zaretskii
2017-04-21 16:41 ` Yao Qi
2017-04-21 10:50 ` [PATCH v2 4/8] Python: Remove ptid from gdb.Record interface Tim Wiederhake
2017-04-21 12:20 ` Eli Zaretskii
2017-04-21 10:50 ` [PATCH v2 8/8] Python: Introduce gdb.Instruction class Tim Wiederhake
2017-04-21 12:19 ` Eli Zaretskii
2017-04-24 5:34 ` Wiederhake, Tim
2017-04-21 18:10 ` Yao Qi
2017-04-21 10:50 ` [PATCH v2 1/8] Python: Fix indentation in py-record-btrace.c Tim Wiederhake
2017-04-21 10:50 ` [PATCH v2 3/8] Python: Use correct ptid in btrace recording Tim Wiederhake
2017-04-21 14:49 ` Yao Qi
2017-04-21 10:50 ` [PATCH v2 6/8] Python: Move and rename gdb.BtraceInstruction Tim Wiederhake
2017-04-21 12:23 ` Eli Zaretskii
2017-04-21 15:21 ` Yao Qi
2017-04-21 10:50 ` [PATCH v2 2/8] Python: Fix exception handling in py-record-btrace.c Tim Wiederhake
2017-04-21 18:08 ` Yao Qi
2017-04-27 16:35 ` Pedro Alves
2017-04-21 10:50 ` [PATCH v2 5/8] Python: Introduce gdb.RecordGap class Tim Wiederhake
2017-04-21 12:25 ` Eli Zaretskii
2017-04-21 14:50 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86y3utzufy.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=tim.wiederhake@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox