From: Eli Zaretskii <eliz@gnu.org>
To: Tim Wiederhake <tim.wiederhake@intel.com>
Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com,
brobecker@adacore.com, qiyaoltc@gmail.com
Subject: Re: [PATCH v2 8/8] Python: Introduce gdb.Instruction class
Date: Fri, 21 Apr 2017 12:19:00 -0000 [thread overview]
Message-ID: <83tw5i9clk.fsf@gnu.org> (raw)
In-Reply-To: <1492771786-26372-9-git-send-email-tim.wiederhake@intel.com> (message from Tim Wiederhake on Fri, 21 Apr 2017 12:49:46 +0200)
> From: Tim Wiederhake <tim.wiederhake@intel.com>
> Cc: markus.t.metzger@intel.com, brobecker@adacore.com, qiyaoltc@gmail.com
> Date: Fri, 21 Apr 2017 12:49:46 +0200
>
> +@defvar RecordInstruction.number
> +An integer identifying this instruction. @var{number} corresponds to
@var is wrong here; please use @code instead. (Yes, I know it was
that way in theoriginal text.)
Otherwise, the documentation part is approved.
Thanks.
next prev parent reply other threads:[~2017-04-21 12:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 10:50 [PATCH v2 0/8] Python bindings for GDB record Tim Wiederhake
2017-04-21 10:50 ` [PATCH v2 5/8] Python: Introduce gdb.RecordGap class Tim Wiederhake
2017-04-21 12:25 ` Eli Zaretskii
2017-04-21 14:50 ` Yao Qi
2017-04-21 10:50 ` [PATCH v2 2/8] Python: Fix exception handling in py-record-btrace.c Tim Wiederhake
2017-04-21 18:08 ` Yao Qi
2017-04-27 16:35 ` Pedro Alves
2017-04-21 10:50 ` [PATCH v2 3/8] Python: Use correct ptid in btrace recording Tim Wiederhake
2017-04-21 14:49 ` Yao Qi
2017-04-21 10:50 ` [PATCH v2 6/8] Python: Move and rename gdb.BtraceInstruction Tim Wiederhake
2017-04-21 12:23 ` Eli Zaretskii
2017-04-21 15:21 ` Yao Qi
2017-04-21 10:50 ` [PATCH v2 1/8] Python: Fix indentation in py-record-btrace.c Tim Wiederhake
2017-04-21 10:50 ` [PATCH v2 7/8] Python: Move and rename gdb.BtraceFunction Tim Wiederhake
2017-04-21 12:22 ` Eli Zaretskii
2017-04-21 16:41 ` Yao Qi
2017-04-21 10:50 ` [PATCH v2 4/8] Python: Remove ptid from gdb.Record interface Tim Wiederhake
2017-04-21 12:20 ` Eli Zaretskii
2017-04-21 10:50 ` [PATCH v2 8/8] Python: Introduce gdb.Instruction class Tim Wiederhake
2017-04-21 12:19 ` Eli Zaretskii [this message]
2017-04-24 5:34 ` Wiederhake, Tim
2017-04-21 18:10 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tw5i9clk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=qiyaoltc@gmail.com \
--cc=tim.wiederhake@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox