Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tim Wiederhake <tim.wiederhake@intel.com>
To: gdb-patches@sourceware.org
Cc: markus.t.metzger@intel.com, brobecker@adacore.com, qiyaoltc@gmail.com
Subject: [PATCH v2 4/8] Python: Remove ptid from gdb.Record interface
Date: Fri, 21 Apr 2017 10:50:00 -0000	[thread overview]
Message-ID: <1492771786-26372-5-git-send-email-tim.wiederhake@intel.com> (raw)
In-Reply-To: <1492771786-26372-1-git-send-email-tim.wiederhake@intel.com>

As discussed here: https://sourceware.org/ml/gdb-patches/2017-04/msg00166.html

2017-04-21  Tim Wiederhake  <tim.wiederhake@intel.com>

gdb/ChangeLog:
	* python/py-record.c (recpy_ptid): Remove.
	(recpy_record_getset): Remove recpy_ptid.

gdb/doc/ChangeLog:
	* python.texi (Recording in Python): Remove Record.ptid defvar.

gdb/testsuite/ChangeLog:
	* gdb.python/py-record-btrace.exp: Remove Record.ptid test.

---
 gdb/doc/python.texi                           |  7 -------
 gdb/python/py-record.c                        | 11 -----------
 gdb/testsuite/gdb.python/py-record-btrace.exp |  1 -
 3 files changed, 19 deletions(-)

diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
index ce5810e..8c246a4 100644
--- a/gdb/doc/python.texi
+++ b/gdb/doc/python.texi
@@ -3110,13 +3110,6 @@ currently active.  All record objects become invalid after this call.
 
 A @code{gdb.Record} object has the following attributes:
 
-@defvar Record.ptid
-ID of the thread associated with this object as a tuple of three integers.  The
-first is the Process ID (PID); the second is the Lightweight Process ID (LWPID),
-and the third is the Thread ID (TID). Either the LWPID or TID may be 0, which
-indicates that the operating system does not use that identifier.
-@end defvar
-
 @defvar Record.method
 A string with the current recording method, e.g.@: @code{full} or
 @code{btrace}.
diff --git a/gdb/python/py-record.c b/gdb/python/py-record.c
index 586687a..bef0784 100644
--- a/gdb/python/py-record.c
+++ b/gdb/python/py-record.c
@@ -29,16 +29,6 @@ static PyTypeObject recpy_record_type = {
   PyVarObject_HEAD_INIT (NULL, 0)
 };
 
-/* Implementation of record.ptid.  */
-
-static PyObject *
-recpy_ptid (PyObject *self, void* closure)
-{
-  const recpy_record_object * const obj = (recpy_record_object *) self;
-
-  return gdbpy_create_ptid_object (obj->ptid);
-}
-
 /* Implementation of record.method.  */
 
 static PyObject *
@@ -161,7 +151,6 @@ Rewind to given location."},
 /* Record member list.  */
 
 static PyGetSetDef recpy_record_getset[] = {
-  { "ptid", recpy_ptid, NULL, "Current thread.", NULL },
   { "method", recpy_method, NULL, "Current recording method.", NULL },
   { "format", recpy_format, NULL, "Current recording format.", NULL },
   { "replay_position", recpy_replay_position, NULL, "Current replay position.",
diff --git a/gdb/testsuite/gdb.python/py-record-btrace.exp b/gdb/testsuite/gdb.python/py-record-btrace.exp
index 7752cac..ecc8bdf 100644
--- a/gdb/testsuite/gdb.python/py-record-btrace.exp
+++ b/gdb/testsuite/gdb.python/py-record-btrace.exp
@@ -59,7 +59,6 @@ with_test_prefix "preopened record btrace" {
 
 with_test_prefix "prepare record" {
     gdb_test_no_output "python r = gdb.start_recording(\"btrace\")"
-    gdb_test "python print(len(r.ptid))" "3"
     gdb_test "python print(r.method)" "btrace"
     gdb_test "python print(r.format)" "pt|bts"
     gdb_test "stepi 100" ".*"
-- 
2.7.4


  parent reply	other threads:[~2017-04-21 10:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21 10:50 [PATCH v2 0/8] Python bindings for GDB record Tim Wiederhake
2017-04-21 10:50 ` [PATCH v2 2/8] Python: Fix exception handling in py-record-btrace.c Tim Wiederhake
2017-04-21 18:08   ` Yao Qi
2017-04-27 16:35   ` Pedro Alves
2017-04-21 10:50 ` [PATCH v2 5/8] Python: Introduce gdb.RecordGap class Tim Wiederhake
2017-04-21 12:25   ` Eli Zaretskii
2017-04-21 14:50   ` Yao Qi
2017-04-21 10:50 ` [PATCH v2 6/8] Python: Move and rename gdb.BtraceInstruction Tim Wiederhake
2017-04-21 12:23   ` Eli Zaretskii
2017-04-21 15:21   ` Yao Qi
2017-04-21 10:50 ` [PATCH v2 3/8] Python: Use correct ptid in btrace recording Tim Wiederhake
2017-04-21 14:49   ` Yao Qi
2017-04-21 10:50 ` [PATCH v2 1/8] Python: Fix indentation in py-record-btrace.c Tim Wiederhake
2017-04-21 10:50 ` [PATCH v2 8/8] Python: Introduce gdb.Instruction class Tim Wiederhake
2017-04-21 12:19   ` Eli Zaretskii
2017-04-24  5:34     ` Wiederhake, Tim
2017-04-21 18:10   ` Yao Qi
2017-04-21 10:50 ` Tim Wiederhake [this message]
2017-04-21 12:20   ` [PATCH v2 4/8] Python: Remove ptid from gdb.Record interface Eli Zaretskii
2017-04-21 10:50 ` [PATCH v2 7/8] Python: Move and rename gdb.BtraceFunction Tim Wiederhake
2017-04-21 12:22   ` Eli Zaretskii
2017-04-21 16:41   ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492771786-26372-5-git-send-email-tim.wiederhake@intel.com \
    --to=tim.wiederhake@intel.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@intel.com \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox