Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: "Wiederhake\, Tim" <tim.wiederhake@intel.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/6] DWARF: Don't add nameless modules to partial symbol table.
Date: Wed, 02 Aug 2017 11:16:00 -0000	[thread overview]
Message-ID: <86y3r22p9n.fsf@gmail.com> (raw)
In-Reply-To: <9676A094AF46E14E8265E7A3F4CCE9AF5AC185A5@IRSMSX106.ger.corp.intel.com>	(Tim Wiederhake's message of "Tue, 1 Aug 2017 12:47:44 +0000")

"Wiederhake, Tim" <tim.wiederhake@intel.com> writes:

> I'm using the Intel? Fortran Compiler:
>
> $ ifort --version
> ifort (IFORT) 15.0.0 20140716
> Copyright (C) 1985-2014 Intel Corporation.  All rights reserved.
>
> $ ifort -g -o block-data testsuite/gdb.fortran/block-data.f
> $ readelf -w block-data | grep DW_TAG_module
>  <1><d7>: Abbrev Number: 7 (DW_TAG_module)
>    7      DW_TAG_module    [has children]

Hi Tim,
I checked both gfortran and armflang, neither generate DW_TAG_module for
nameless BLOCK DATA.

When I google "block data", I find I reviewed this patch before :)
https://sourceware.org/ml/gdb-patches/2016-11/msg00014.html I didn't see
the point Intel fortran compiler generates DW_TAG_module for a nameless
BLOCK DATA, but GDB shouldn't crash in any case.  Could you adjust the
commit log and comments to reflect that Intel fortran compiler
generates DW_TAG_module without DW_AT_name for a nameless BLOCK DATA,
and GDB will crash.  This patch is to fix the crash.

-- 
Yao (齐尧)


  reply	other threads:[~2017-08-02 11:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21  9:25 [PATCH 0/6] Some Fortran patches Tim Wiederhake
2017-07-21  9:25 ` [PATCH 2/6] Fortran: Accessing fields of inherited types via fully qualified name Tim Wiederhake
2017-07-21  9:25 ` [PATCH 1/6] DWARF: Don't add nameless modules to partial symbol table Tim Wiederhake
2017-07-31 22:09   ` Yao Qi
2017-08-01 12:47     ` Wiederhake, Tim
2017-08-02 11:16       ` Yao Qi [this message]
2017-08-04 11:03         ` Wiederhake, Tim
2017-07-21  9:25 ` [PATCH 5/6] Fortran: Enable setting breakpoint on nested functions Tim Wiederhake
2017-07-21  9:25 ` [PATCH 4/6] Dwarf: Fortran, support DW_TAG_entry_point Tim Wiederhake
2017-07-31 22:20   ` Yao Qi
2017-08-02 13:14   ` Yao Qi
     [not found]     ` <9676A094AF46E14E8265E7A3F4CCE9AF5AC20F28@irsmsx105.ger.corp.intel.com>
2017-08-07  8:46       ` Wiederhake, Tim
2017-08-07 11:29       ` Yao Qi
2017-08-08 14:36         ` Wiederhake, Tim
2017-07-21  9:25 ` [PATCH 3/6] Fortran: Ptype, print type extension Tim Wiederhake
2017-08-07 12:08   ` Yao Qi
2017-07-21  9:25 ` [PATCH 6/6] Fortran: Nested functions, add scope parameter Tim Wiederhake
2017-07-28  8:19 ` [PATCH 0/6] Some Fortran patches Wiederhake, Tim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y3r22p9n.fsf@gmail.com \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tim.wiederhake@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox