RE: [PATCH 1/6] DWARF: Don't add nameless modules to partial symbol table.

["Wiederhake, Tim" <tim.wiederhake@intel.com>]

Hi Yao,

Thank you for your response.

I'm using the Intel? Fortran Compiler:

$ ifort --version
ifort (IFORT) 15.0.0 20140716
Copyright (C) 1985-2014 Intel Corporation.  All rights reserved.

$ ifort -g -o block-data testsuite/gdb.fortran/block-data.f
$ readelf -w block-data | grep DW_TAG_module
 <1><d7>: Abbrev Number: 7 (DW_TAG_module)
   7      DW_TAG_module    [has children]

Regards,
Tim


> -----Original Message-----
> From: Yao Qi [mailto:qiyaoltc@gmail.com]
> Sent: Tuesday, August 1, 2017 12:10 AM
> To: Wiederhake, Tim <tim.wiederhake@intel.com>
> Cc: gdb-patches@sourceware.org; Bernhard Heckel
> <bernhard.heckel@intel.com>
> Subject: Re: [PATCH 1/6] DWARF: Don't add nameless modules to partial
> symbol table.
> 
> On 17-07-21 11:23:55, Tim Wiederhake wrote:
> > From: Bernhard Heckel <bernhard.heckel@intel.com>
> >
> > A name for BLOCK DATA in Fortran is optional.  If no name has been
> assigned,
> > GDB will crash during read-in of DWARF when BLOCK DATA is represented
> via
> > DW_TAG_module.
> 
> What is your Fortran compiler?  I used gfortran 4.9.4, it doesn't generate
> DW_TAG_module in debug information.  So, I run block-data.exp with
> unpatched GDB, all tests pass.
> 
> >
> > BLOCK DATA is used for one-time initialization of non-pointer variables
> in
> > named common blocks.
> >
> > xxxx-yy-zz  Bernhard Heckel  <bernhard.heckel@intel.com>
> >
> > gdb/ChangeLog:
> > 	* dwarf2read.c (add_partial_symbol): Skip nameless modules.
> >
> > gdb/testsuite/ChangeLog:
> > 	* gdb.fortran/block-data.f: New file.
> > 	* gdb.fortran/block-data.exp: New file.
> >
> 
> 
> --
> Yao (齐尧)
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928