From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81183 invoked by alias); 2 Aug 2017 11:16:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79475 invoked by uid 89); 2 Aug 2017 11:16:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=rights, H*r:sk:static., reserved, corporation X-HELO: mail-it0-f45.google.com Received: from mail-it0-f45.google.com (HELO mail-it0-f45.google.com) (209.85.214.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Aug 2017 11:16:43 +0000 Received: by mail-it0-f45.google.com with SMTP id 77so22046725itj.1 for ; Wed, 02 Aug 2017 04:16:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=YAFaKXEbRnHxqJlJJMMd6McbPymZh/07v+qSNexkK8w=; b=OzWxqbXQPikh1egWqI/Y6qdwO6f/ELA0YfGyVuZ0kQ5L6dYykepOMpUhz7ixApNe9B hdQWpyZF3bx9sB/ahgDRiLEg7SdfgyQFGsC40TP1Z1i+kxB25hx2me5e+mOABnUbOI18 hKi5kZgw//MjjYFx/REMw6/rEWx+QFAgisyy7HKYSnBgJVI7ULZr8MWrq2dzS+Tzd1Vz RaUZoerHzztIixKD7ZTRJphM8JbjKL3EJQvg2hl8Xi446UvQvP8rWUY1j7IVsYSbh23w ECdD2ACimY/mL5w4/y/XIzfS4EcN8u+fz2iE34dLVy6WsiWQwzB7b8VYxCOIvMNwVVfr rCAQ== X-Gm-Message-State: AIVw110YXOp/fUhgzuUqhns7dqVXGnR6uSksH0cbwZLmnn8Z/JXC3nhJ RJ4gS2Ept8zJUNTZ X-Received: by 10.36.249.131 with SMTP id l125mr5297986ith.73.1501672601930; Wed, 02 Aug 2017 04:16:41 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id g5sm15208820iof.85.2017.08.02.04.16.40 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 02 Aug 2017 04:16:41 -0700 (PDT) From: Yao Qi To: "Wiederhake\, Tim" Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH 1/6] DWARF: Don't add nameless modules to partial symbol table. References: <1500629040-12972-1-git-send-email-tim.wiederhake@intel.com> <1500629040-12972-2-git-send-email-tim.wiederhake@intel.com> <20170731220938.GB8039@1170ee0b50d5> <9676A094AF46E14E8265E7A3F4CCE9AF5AC185A5@IRSMSX106.ger.corp.intel.com> Date: Wed, 02 Aug 2017 11:16:00 -0000 In-Reply-To: <9676A094AF46E14E8265E7A3F4CCE9AF5AC185A5@IRSMSX106.ger.corp.intel.com> (Tim Wiederhake's message of "Tue, 1 Aug 2017 12:47:44 +0000") Message-ID: <86y3r22p9n.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00023.txt.bz2 "Wiederhake, Tim" writes: > I'm using the Intel? Fortran Compiler: > > $ ifort --version > ifort (IFORT) 15.0.0 20140716 > Copyright (C) 1985-2014 Intel Corporation. All rights reserved. > > $ ifort -g -o block-data testsuite/gdb.fortran/block-data.f > $ readelf -w block-data | grep DW_TAG_module > <1>: Abbrev Number: 7 (DW_TAG_module) > 7 DW_TAG_module [has children] Hi Tim, I checked both gfortran and armflang, neither generate DW_TAG_module for nameless BLOCK DATA. When I google "block data", I find I reviewed this patch before :) https://sourceware.org/ml/gdb-patches/2016-11/msg00014.html I didn't see the point Intel fortran compiler generates DW_TAG_module for a nameless BLOCK DATA, but GDB shouldn't crash in any case. Could you adjust the commit log and comments to reflect that Intel fortran compiler generates DW_TAG_module without DW_AT_name for a nameless BLOCK DATA, and GDB will crash. This patch is to fix the crash. --=20 Yao (=E9=BD=90=E5=B0=A7)