From: Mark Kettenis <kettenis@chello.nl>
To: gdb-patches@sources.redhat.com
Cc: vinschen@redhat.com
Subject: Re: [RFA] i386-tdep.c: Remove call to inside_entry_file
Date: Sun, 06 Apr 2003 16:38:00 -0000 [thread overview]
Message-ID: <86u1db8tu8.fsf@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: Corinna Vinschen's message of "Tue, 1 Apr 2003 17:44:01 +0200"
Corinna Vinschen <vinschen@redhat.com> writes:
> Hi,
>
> as suggested by Andrew I'm sending this patch separately. I've checked
> the patch for i686-pc-linux and i686-pc-cygwin. Linux is unaffected
> (no change in testsuite results), Cygwin has additional PASSes in
> asm-source.exp.
>
> If the change is unacceptable for some reason, I'd add a new frame_chain
> function to i386-cygwin-tdep.c. I've added this as an alternative patch.
Hi Corinna,
I'm sorry, but yes, I think the change is not obviously right. There
are i386 targets that do not correctly terminate the frame chain, that
is, they do not mark the deepest stack frame as such by setting %ebp
to zero. The inside_entry_file() check is there to prevent GDB from
walking off the stack on such targets.
Therefore, I think it's best to apply your alternative patch. Your
second version is herewith approved.
Mark
next prev parent reply other threads:[~2003-04-06 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-01 15:44 Corinna Vinschen
2003-04-01 15:57 ` Andrew Cagney
2003-04-01 16:21 ` Corinna Vinschen
2003-04-06 16:38 ` Mark Kettenis [this message]
2003-04-10 13:19 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86u1db8tu8.fsf@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox