From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 919 invoked by alias); 6 Apr 2003 16:38:21 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 893 invoked from network); 6 Apr 2003 16:38:19 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.212) by sources.redhat.com with SMTP; 6 Apr 2003 16:38:19 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6/8.12.5) with ESMTP id h36GcBi3000257; Sun, 6 Apr 2003 18:38:11 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6/8.12.6) with ESMTP id h36GcBO2000296; Sun, 6 Apr 2003 18:38:11 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6/8.12.6/Submit) id h36Gc7vs000293; Sun, 6 Apr 2003 18:38:07 +0200 (CEST) To: gdb-patches@sources.redhat.com Cc: vinschen@redhat.com Subject: Re: [RFA] i386-tdep.c: Remove call to inside_entry_file References: <20030401154401.GA13001@cygbert.vinschen.de> From: Mark Kettenis Date: Sun, 06 Apr 2003 16:38:00 -0000 In-Reply-To: Corinna Vinschen's message of "Tue, 1 Apr 2003 17:44:01 +0200" Message-ID: <86u1db8tu8.fsf@elgar.kettenis.dyndns.org> X-SW-Source: 2003-04/txt/msg00100.txt.bz2 Corinna Vinschen writes: > Hi, > > as suggested by Andrew I'm sending this patch separately. I've checked > the patch for i686-pc-linux and i686-pc-cygwin. Linux is unaffected > (no change in testsuite results), Cygwin has additional PASSes in > asm-source.exp. > > If the change is unacceptable for some reason, I'd add a new frame_chain > function to i386-cygwin-tdep.c. I've added this as an alternative patch. Hi Corinna, I'm sorry, but yes, I think the change is not obviously right. There are i386 targets that do not correctly terminate the frame chain, that is, they do not mark the deepest stack frame as such by setting %ebp to zero. The inside_entry_file() check is there to prevent GDB from walking off the stack on such targets. Therefore, I think it's best to apply your alternative patch. Your second version is herewith approved. Mark