Re: [PATCH] Fix racy test in gdb.threads/thread-specific-bp.exp

[Yao Qi <qiyaoltc@gmail.com>]

Simon Marchi <simon.marchi@polymtl.ca> writes:

> I am not sure I understand what this is supposed to match.  First are
> the parenthesis useful, since we're not using any capture group?

I don't capture anything.

> Then, .* followed with [^\r\n]* doesn't seem useful, since the .* can
> just match anything the [^\r\n]* doesn't match.
>
> What about just this?
>
> 	set test "continue to end"
> 	gdb_test_multiple "$cmd" $test {
> 	    -re "hit Breakpoint $decimal, end \\(\\) at.*$gdb_prompt " {

We should still keep \r\n before $gdb_prompt.

> 		pass $test
> 	    }
> 	}

The original pattern is "end .* at", so I want to leave it there, and
change it to

	set test "continue to end"
	gdb_test_multiple "$cmd" $test {
	    -re "Breakpoint .* end .* at .*\r\n$gdb_prompt " {
		pass $test
	    }
	}

-- 
Yao (齐尧)