From: Simon Marchi <simon.marchi@polymtl.ca>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix racy test in gdb.threads/thread-specific-bp.exp
Date: Tue, 04 Apr 2017 13:37:00 -0000 [thread overview]
Message-ID: <4e7ce9b9f15a3e14e162778116fe7bde@polymtl.ca> (raw)
In-Reply-To: <86r318zjbq.fsf@gmail.com>
On 2017-04-04 04:08, Yao Qi wrote:
>> Then, .* followed with [^\r\n]* doesn't seem useful, since the .* can
>> just match anything the [^\r\n]* doesn't match.
>>
>> What about just this?
>>
>> set test "continue to end"
>> gdb_test_multiple "$cmd" $test {
>> -re "hit Breakpoint $decimal, end \\(\\) at.*$gdb_prompt " {
>
> We should still keep \r\n before $gdb_prompt.
>
>> pass $test
>> }
>> }
>
> The original pattern is "end .* at", so I want to leave it there, and
> change it to
>
> set test "continue to end"
> gdb_test_multiple "$cmd" $test {
> -re "Breakpoint .* end .* at .*\r\n$gdb_prompt " {
> pass $test
> }
> }
LGTM.
prev parent reply other threads:[~2017-04-04 13:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 21:06 Yao Qi
2017-04-04 1:49 ` Simon Marchi
2017-04-04 8:08 ` Yao Qi
2017-04-04 13:37 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e7ce9b9f15a3e14e162778116fe7bde@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox