From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-137940-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 110923 invoked by alias); 4 Apr 2017 13:37:16 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 110842 invoked by uid 89); 4 Apr 2017 13:37:16 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Hx-languages-length:697
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Apr 2017 13:37:14 +0000
Received: by simark.ca (Postfix, from userid 33)	id E07FB1E881; Tue,  4 Apr 2017 09:37:13 -0400 (EDT)
To: Yao Qi <qiyaoltc@gmail.com>
Subject: Re: [PATCH] Fix racy test in gdb.threads/thread-specific-bp.exp
X-PHP-Originating-Script: 33:rcube.php
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Tue, 04 Apr 2017 13:37:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
In-Reply-To: <86r318zjbq.fsf@gmail.com>
References: <1491253593-4116-1-git-send-email-yao.qi@linaro.org> <27d2906cc62411453861a5868a38bff8@polymtl.ca> <86r318zjbq.fsf@gmail.com>
Message-ID: <4e7ce9b9f15a3e14e162778116fe7bde@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.2.4
X-IsSubscribed: yes
X-SW-Source: 2017-04/txt/msg00024.txt.bz2

On 2017-04-04 04:08, Yao Qi wrote:
>> Then, .* followed with [^\r\n]* doesn't seem useful, since the .* can
>> just match anything the [^\r\n]* doesn't match.
>> 
>> What about just this?
>> 
>> 	set test "continue to end"
>> 	gdb_test_multiple "$cmd" $test {
>> 	    -re "hit Breakpoint $decimal, end \\(\\) at.*$gdb_prompt " {
> 
> We should still keep \r\n before $gdb_prompt.
> 
>> 		pass $test
>> 	    }
>> 	}
> 
> The original pattern is "end .* at", so I want to leave it there, and
> change it to
> 
> 	set test "continue to end"
> 	gdb_test_multiple "$cmd" $test {
> 	    -re "Breakpoint .* end .* at .*\r\n$gdb_prompt " {
> 		pass $test
> 	    }
> 	}

LGTM.