From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72079 invoked by alias); 4 Apr 2017 08:08:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69038 invoked by uid 89); 4 Apr 2017 08:08:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr0-f176.google.com Received: from mail-wr0-f176.google.com (HELO mail-wr0-f176.google.com) (209.85.128.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Apr 2017 08:08:15 +0000 Received: by mail-wr0-f176.google.com with SMTP id w43so202371297wrb.0 for ; Tue, 04 Apr 2017 01:08:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=zwNrbUsJywOWi368wEgCqwf+JareDZ/Ddb8cSJbxCww=; b=pnpBZIxPMxfk3dSZ3XeWvKO9qv2fSUTgV4heM1Let8RLw/n2P64qBFwnigdxT2ZxLN ogdNWFOSJjS1X71Z25fCghFEudiwoa0Kl8EDcBfWbrNtcnVGG+xqpxXmpPnEIzbQ2/FM iMeBq9kSjcyXoL4gsr5alNOxCNgq4R02JFC9yILm4hPqSUbKHVlgytN00rri4MC6yNca Io0XEdqpuTNqIESnbWAeMAOw1qWzeU0kVQMrZBz7VKVEzAUNv2olmPAaAmkUuEuR/ijq rGNISzy+wEtDFDoH+wDxyEMCVih3pjf9gd7SEI2HYy+pRqIIH+TRXuf4HYf3jSQwHRS6 5Y3w== X-Gm-Message-State: AFeK/H0ecTxxDD2AtCN4Ut8wcMGQnVQOxVjPAnjyPyh+Lc0j3zpt06DFJEUFRdK+iOehsQ== X-Received: by 10.223.166.97 with SMTP id k88mr18189008wrc.33.1491293293757; Tue, 04 Apr 2017 01:08:13 -0700 (PDT) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id d7sm11245459wrc.6.2017.04.04.01.08.12 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 04 Apr 2017 01:08:13 -0700 (PDT) From: Yao Qi To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix racy test in gdb.threads/thread-specific-bp.exp References: <1491253593-4116-1-git-send-email-yao.qi@linaro.org> <27d2906cc62411453861a5868a38bff8@polymtl.ca> Date: Tue, 04 Apr 2017 08:08:00 -0000 In-Reply-To: <27d2906cc62411453861a5868a38bff8@polymtl.ca> (Simon Marchi's message of "Mon, 03 Apr 2017 21:49:01 -0400") Message-ID: <86r318zjbq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00008.txt.bz2 Simon Marchi writes: > I am not sure I understand what this is supposed to match. First are > the parenthesis useful, since we're not using any capture group? I don't capture anything. > Then, .* followed with [^\r\n]* doesn't seem useful, since the .* can > just match anything the [^\r\n]* doesn't match. > > What about just this? > > set test "continue to end" > gdb_test_multiple "$cmd" $test { > -re "hit Breakpoint $decimal, end \\(\\) at.*$gdb_prompt " { We should still keep \r\n before $gdb_prompt. > pass $test > } > } The original pattern is "end .* at", so I want to leave it there, and change it to set test "continue to end" gdb_test_multiple "$cmd" $test { -re "Breakpoint .* end .* at .*\r\n$gdb_prompt " { pass $test } } --=20 Yao (=E9=BD=90=E5=B0=A7)