From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 00/10 v2] Remove regcache::m_readonly_p
Date: Wed, 21 Feb 2018 11:22:00 -0000 [thread overview]
Message-ID: <86po4yio4a.fsf@gmail.com> (raw)
In-Reply-To: <e11f259af1b304cea5b7722d1df07279@polymtl.ca> (Simon Marchi's message of "Fri, 16 Feb 2018 22:53:29 -0500")
Simon Marchi <simon.marchi@polymtl.ca> writes:
> I did not spot anything fundamentally wrong in the series, though I'm
> not very proficient in this area. I sent a few minor comments, but
> other than that I'm fine with the series. It's hard to tell whether
> it's the right design, but I think it improves things by splitting the
> concerns in different classes rather than having one do-it-all class.
Hi Simon,
Thanks for the review. I update these patches as you commented. I
pushed them in.
--
Yao (齐尧)
prev parent reply other threads:[~2018-02-21 11:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 10:33 Yao Qi
2018-02-07 10:33 ` [PATCH 02/10] class readable_regcache and pass readable_regcache to gdbarch pseudo_register_read and pseudo_register_read_value Yao Qi
2018-02-07 10:33 ` [PATCH 01/10] Class reg_buffer Yao Qi
2018-02-07 10:33 ` [PATCH 04/10] Class readonly_detached_regcache Yao Qi
2018-02-07 10:33 ` [PATCH 08/10] Remove regcache::m_readonly_p Yao Qi
2018-02-07 10:33 ` [PATCH 03/10] Remove regcache_save and regcache_cpy Yao Qi
2018-02-17 2:07 ` Simon Marchi
2018-02-07 10:33 ` [PATCH 10/10] Pass readable_regcache to gdbarch method read_pc Yao Qi
2018-02-07 10:33 ` [PATCH 07/10] No longer create readonly regcache Yao Qi
2018-02-07 10:33 ` [PATCH 09/10] Move register_dump to regcache-dump.c Yao Qi
2018-02-17 3:50 ` Simon Marchi
2018-02-21 8:27 ` Yao Qi
2018-02-21 12:57 ` Simon Marchi
2018-02-21 13:59 ` Yao Qi
2018-02-21 14:49 ` Simon Marchi
2018-02-07 10:33 ` [PATCH 05/10] Class detached_regcache Yao Qi
2018-02-17 3:15 ` Simon Marchi
2018-02-17 3:53 ` [PATCH 00/10 v2] Remove regcache::m_readonly_p Simon Marchi
2018-02-21 11:22 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86po4yio4a.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox