From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92504 invoked by alias); 21 Feb 2018 11:22:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92489 invoked by uid 89); 21 Feb 2018 11:22:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-wr0-f178.google.com Received: from mail-wr0-f178.google.com (HELO mail-wr0-f178.google.com) (209.85.128.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Feb 2018 11:22:20 +0000 Received: by mail-wr0-f178.google.com with SMTP id n7so3429698wrn.5 for ; Wed, 21 Feb 2018 03:22:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=/OBh/AYcbXmk0CSGk4bSf/Tfk6dIJQH2IQVhkIYbELs=; b=F5styNWV7AZ1PAPvmFyQGJ/6/K6vl85Sa6ijtZIRegQbEQBz7JgrjaNJ4+Bmg8QL0z RP3TMkjxOcq+8g+fiTHWcJqOGICsseaAcj+dUG4R6YKrVLC+k4SAPTYpIVSw7E4MVx8A rWZlIlDdY5nFAEEjDhnKeVuzENs9ximL2paSNLT0Ao2nr5ZhoNcuvR0w6zSq2sCphhEy 6EMhkjFCXpjxivQXwC9/sa+TGyRAuFNrerQwSkasqb8RYvEM1TMBfRoRCx96l0h+n81l t3nZWO189QDUTJy5jC1WnddBcSaDTYVyjW411IMKZ3MyhTZM6/wIq8FVsxtDZe65wh4N x3Xg== X-Gm-Message-State: APf1xPDJThk554k+RQVnWXioWIIVvE27vW6kmC49RRfvPIN4H3iBo6Gk E/cJ4i4oFE+FT0JP5XXQ1hcpBgCs X-Google-Smtp-Source: AH8x225AWAs/XCAxYBZny/f2qr48CmsCY8rvsmra/WKNYQlOqdMpIp7gIdoey2cKJfVbtxA2Yfhkug== X-Received: by 10.223.157.200 with SMTP id q8mr2580889wre.71.1519212138044; Wed, 21 Feb 2018 03:22:18 -0800 (PST) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id e67sm64697290wmf.7.2018.02.21.03.22.17 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 21 Feb 2018 03:22:17 -0800 (PST) From: Yao Qi To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 00/10 v2] Remove regcache::m_readonly_p References: <1517999572-14987-1-git-send-email-yao.qi@linaro.org> Date: Wed, 21 Feb 2018 11:22:00 -0000 In-Reply-To: (Simon Marchi's message of "Fri, 16 Feb 2018 22:53:29 -0500") Message-ID: <86po4yio4a.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00287.txt.bz2 Simon Marchi writes: > I did not spot anything fundamentally wrong in the series, though I'm > not very proficient in this area. I sent a few minor comments, but > other than that I'm fine with the series. It's hard to tell whether > it's the right design, but I think it improves things by splitting the > concerns in different classes rather than having one do-it-all class. Hi Simon, Thanks for the review. I update these patches as you commented. I pushed them in. --=20 Yao (=E9=BD=90=E5=B0=A7)