From: Simon Marchi <simon.marchi@polymtl.ca>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 09/10] Move register_dump to regcache-dump.c
Date: Wed, 21 Feb 2018 12:57:00 -0000 [thread overview]
Message-ID: <ead1cc4666c2644dc3c740f60ee87d24@polymtl.ca> (raw)
In-Reply-To: <CAH=s-PO4iN2sSSm-kv9USnx3u6mjigQ2X1kp1JMG4urq0_L=Fw@mail.gmail.com>
On 2018-02-21 03:27, Yao Qi wrote:
> On Sat, Feb 17, 2018 at 3:50 AM, Simon Marchi <simon.marchi@polymtl.ca>
> wrote:
>> I think it would make sense to move the remaining dump-related things
>> (the
>> register_dump class, the register_dump::dump implementation) to
>> regcache-dump.c.
>>
>
> register_dump::dump accesses 'struct regcache_desc', which is declared
> in
> regcache.c, so that register_dump::dump can't be moved to
> regcache-dump.c.
Is there any reason we can't move struct regcache_descr to regcache.h?
next prev parent reply other threads:[~2018-02-21 12:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 10:33 [PATCH 00/10 v2] Remove regcache::m_readonly_p Yao Qi
2018-02-07 10:33 ` [PATCH 08/10] " Yao Qi
2018-02-07 10:33 ` [PATCH 10/10] Pass readable_regcache to gdbarch method read_pc Yao Qi
2018-02-07 10:33 ` [PATCH 03/10] Remove regcache_save and regcache_cpy Yao Qi
2018-02-17 2:07 ` Simon Marchi
2018-02-07 10:33 ` [PATCH 09/10] Move register_dump to regcache-dump.c Yao Qi
2018-02-17 3:50 ` Simon Marchi
2018-02-21 8:27 ` Yao Qi
2018-02-21 12:57 ` Simon Marchi [this message]
2018-02-21 13:59 ` Yao Qi
2018-02-21 14:49 ` Simon Marchi
2018-02-07 10:33 ` [PATCH 07/10] No longer create readonly regcache Yao Qi
2018-02-07 10:33 ` [PATCH 05/10] Class detached_regcache Yao Qi
2018-02-17 3:15 ` Simon Marchi
2018-02-07 10:33 ` [PATCH 02/10] class readable_regcache and pass readable_regcache to gdbarch pseudo_register_read and pseudo_register_read_value Yao Qi
2018-02-07 10:33 ` [PATCH 04/10] Class readonly_detached_regcache Yao Qi
2018-02-07 10:33 ` [PATCH 01/10] Class reg_buffer Yao Qi
2018-02-17 3:53 ` [PATCH 00/10 v2] Remove regcache::m_readonly_p Simon Marchi
2018-02-21 11:22 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ead1cc4666c2644dc3c740f60ee87d24@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox