Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: Philipp Rudo <prudo@linux.vnet.ibm.com>,
	 "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
	 nd <nd@arm.com>
Subject: Re: [PATCH] Move arch/tdesc.h to common/common-tdesc.h
Date: Tue, 06 Feb 2018 16:28:00 -0000	[thread overview]
Message-ID: <86k1vqjd5s.fsf@gmail.com> (raw)
In-Reply-To: <59984094-96C1-4D84-89F6-384769471005@arm.com> (Alan Hayward's	message of "Thu, 1 Feb 2018 13:19:47 +0000")

Alan Hayward <Alan.Hayward@arm.com> writes:

> That results in common/tdesc.h and gdbserver/tdesc.h
> That’s not a problem by itself, because we can just prefix the dir
> name as part of the include.
>

I don't see how does the name of *.c file affect the name of *.h file.
We can still use common/tdesc.h no matter what the *.c name is.

> My next set of patches will then add common/tdesc.c.
> This is slightly more tricky because we now build two tdesc.o files.

I am inclined to create common/ directory in gdb and gdbserver build
tree, and put the object files in the right directory.

> The gdbserver IPA rules will need tweaking, and I’m not sure the OBS
> list will work as it is (given it doesn’t have any dir names).
>
> Like you, I wasn’t sure if there was a naming convention for common/.
> In the end I went with the easiest solution :)

-- 
Yao (齐尧)


  reply	other threads:[~2018-02-06 16:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31 13:40 Alan Hayward
2018-02-01 11:19 ` Philipp Rudo
2018-02-01 13:19   ` Alan Hayward
2018-02-06 16:28     ` Yao Qi [this message]
2018-02-06 17:56       ` Philipp Rudo
2018-02-06 21:24         ` Yao Qi
2018-02-07  9:02           ` Philipp Rudo
2018-02-07  9:32             ` Yao Qi
2018-02-07 10:31               ` Alan Hayward
2018-02-20 11:56                 ` Alan Hayward
2018-02-21 12:27                   ` Philipp Rudo
2018-02-22 14:17                   ` Yao Qi
2018-02-27 12:13                   ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86k1vqjd5s.fsf@gmail.com \
    --to=qiyaoltc@gmail.com \
    --cc=Alan.Hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    --cc=prudo@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox