From: Yao Qi <qiyaoltc@gmail.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: Philipp Rudo <prudo@linux.vnet.ibm.com>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH] Move arch/tdesc.h to common/common-tdesc.h
Date: Tue, 27 Feb 2018 12:13:00 -0000 [thread overview]
Message-ID: <868tbeiq9x.fsf@gmail.com> (raw)
In-Reply-To: <CF1310CF-73E4-43FD-A418-DACABCC9A246@arm.com> (Alan Hayward's message of "Tue, 20 Feb 2018 11:56:18 +0000")
Alan Hayward <Alan.Hayward@arm.com> writes:
> Tested by build for x86, ppc and aarch64, using both make 4.1 and make 3.81.
> Ran unittests for x86. Checked that my later patch series can apply on top.
Looks this patch breaks the GDBserver build on aarch64-linux,
g++ -x c++ -std=gnu++11 -g -O2 -I. -I../../../binutils-gdb/gdb/gdbserver -I../../../binutils-gdb/gdb/gdbserver/../common -I../../../binutils-gdb/gdb/gdbserver/../regformats -I../../../binutils-gdb/gdb/gdbserver/.. -I../../../binutils-gdb/gdb/gdbserver/../../include -I../../../binutils-gdb/gdb/gdbserver/../gnulib/import -Ibuild-gnulib-gdbserver/import -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized -Wformat-nonliteral -Werror -DGDBSERVER -c -o arch/aarch64.o -MT arch/aarch64.o -MMD -MP -MF arch/.deps/aarch64.Tpo ../../../binutils-gdb/gdb/gdbserver/../arch/aarch64.c
In file included from ../../../binutils-gdb/gdb/gdbserver/../arch/aarch64.h:23:0,
from ../../../binutils-gdb/gdb/gdbserver/../arch/aarch64.c:19:
../../../binutils-gdb/gdb/gdbserver/tdesc.h:57:8: error: ‘char_ptr’ has not been declared
VEC (char_ptr) *features = NULL;
^
../../../binutils-gdb/gdb/gdbserver/tdesc.h:57:16: error: ISO C++ forbids declaration of ‘VEC’ with no type [-fpermissive]
VEC (char_ptr) *features = NULL;
^
../../../binutils-gdb/gdb/gdbserver/tdesc.h:57:16: error: expected ‘;’ at end of member declaration
../../../binutils-gdb/gdb/gdbserver/tdesc.h: In destructor ‘target_desc::~target_desc()’:
../../../binutils-gdb/gdb/gdbserver/tdesc.h:82:30: error: ‘char_ptr’ was not declared in this scope
for (i = 0; VEC_iterate (char_ptr, features, i, f); i++)
^
../../../binutils-gdb/gdb/gdbserver/tdesc.h:82:54: error: ‘VEC_iterate’ was not declared in this scope
for (i = 0; VEC_iterate (char_ptr, features, i, f); i++)
^
../../../binutils-gdb/gdb/gdbserver/tdesc.h:84:15: error: ‘char_ptr’ was not declared in this scope
VEC_free (char_ptr, features);
^
../../../binutils-gdb/gdb/gdbserver/tdesc.h:84:33: error: ‘VEC_free’ was not declared in this scope
VEC_free (char_ptr, features);
^
make[4]: *** [arch/aarch64.o] Error 1
--
Yao (齐尧)
prev parent reply other threads:[~2018-02-27 12:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 13:40 Alan Hayward
2018-02-01 11:19 ` Philipp Rudo
2018-02-01 13:19 ` Alan Hayward
2018-02-06 16:28 ` Yao Qi
2018-02-06 17:56 ` Philipp Rudo
2018-02-06 21:24 ` Yao Qi
2018-02-07 9:02 ` Philipp Rudo
2018-02-07 9:32 ` Yao Qi
2018-02-07 10:31 ` Alan Hayward
2018-02-20 11:56 ` Alan Hayward
2018-02-21 12:27 ` Philipp Rudo
2018-02-22 14:17 ` Yao Qi
2018-02-27 12:13 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868tbeiq9x.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
--cc=prudo@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox