From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24101 invoked by alias); 27 Feb 2018 12:13:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24087 invoked by uid 89); 27 Feb 2018 12:13:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f66.google.com Received: from mail-wm0-f66.google.com (HELO mail-wm0-f66.google.com) (74.125.82.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Feb 2018 12:13:54 +0000 Received: by mail-wm0-f66.google.com with SMTP id t3so23623805wmc.2 for ; Tue, 27 Feb 2018 04:13:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=eGG1ltKMfe2G83ygVW2uptkwYcPkKT8HPzSvCITCIy0=; b=aMXKXpW3y5ZNfg5JlybN8+7H7naHNjLc/y5Axgo2Giw8atu1tObr4o6vSrvgVhm/bv xazDFmvdT45pFw7u22FHAxD+jjkshY+U/b/WJ4ErIr1e+rPBoHVdrdDL8Fuc9UFAPXlI tWIF1oAfyNUM10tRCGfIdmpg9P7ef3gmCteYNY0yP1smIJx/K4nJJSTZJ6XzAsHw+lMM m6r0EbXOaKf8iyG/CBLqHenDBlT2VbIIDC3yElTrX6UmnwtIYR6SxdIYkUTAiiy8yKqJ +qyxuXr6E4+rAETvi5AqomCON3xspOYS07hqcqhvptMLBw0j/x/F39NHDxoJq2jCZUzE tiiw== X-Gm-Message-State: APf1xPAR8mpuc9rcuZ06msRI+FM/boeovgZGzRJo1hI4XZyGlLmsGGFj rXZRUtPWj4McFdzqyxAoxcw= X-Google-Smtp-Source: AG47ELuqT0DjBcU28PmLonKtSkQ6YaYb6/onTXvRCVdMa/HaUbQYoILOw3q1jsjWI9IbjlnIC3AAIA== X-Received: by 10.28.73.2 with SMTP id w2mr10267046wma.129.1519733632627; Tue, 27 Feb 2018 04:13:52 -0800 (PST) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id u63sm20625970wrc.26.2018.02.27.04.13.51 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 27 Feb 2018 04:13:51 -0800 (PST) From: Yao Qi To: Alan Hayward Cc: Philipp Rudo , "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH] Move arch/tdesc.h to common/common-tdesc.h References: <97948063-b3db-fd3a-f62e-b552935cb8dd@arm.com> <20180201121443.43322674@ThinkPad> <59984094-96C1-4D84-89F6-384769471005@arm.com> <86k1vqjd5s.fsf@gmail.com> <20180206185609.3219ef39@ThinkPad> <20180207100202.1ea997bb@ThinkPad> Date: Tue, 27 Feb 2018 12:13:00 -0000 In-Reply-To: (Alan Hayward's message of "Tue, 20 Feb 2018 11:56:18 +0000") Message-ID: <868tbeiq9x.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00424.txt.bz2 Alan Hayward writes: > Tested by build for x86, ppc and aarch64, using both make 4.1 and make 3.= 81. > Ran unittests for x86. Checked that my later patch series can apply on to= p. Looks this patch breaks the GDBserver build on aarch64-linux, g++ -x c++ -std=3Dgnu++11 -g -O2 -I. -I../../../binutils-gdb/gdb/gdbserv= er -I../../../binutils-gdb/gdb/gdbserver/../common -I../../../binutils-gdb/= gdb/gdbserver/../regformats -I../../../binutils-gdb/gdb/gdbserver/.. -I../.= ./../binutils-gdb/gdb/gdbserver/../../include -I../../../binutils-gdb/gdb/g= dbserver/../gnulib/import -Ibuild-gnulib-gdbserver/import -Wall -Wpointer-= arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-su= bscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable = -Wno-sign-compare -Wno-narrowing -Wno-error=3Dmaybe-uninitialized -Wformat-= nonliteral -Werror -DGDBSERVER -c -o arch/aarch64.o -MT arch/aarch64.o -MMD= -MP -MF arch/.deps/aarch64.Tpo ../../../binutils-gdb/gdb/gdbserver/../arch= /aarch64.c In file included from ../../../binutils-gdb/gdb/gdbserver/../arch/aarch64.h= :23:0, from ../../../binutils-gdb/gdb/gdbserver/../arch/aarch64.c= :19: ../../../binutils-gdb/gdb/gdbserver/tdesc.h:57:8: error: =E2=80=98char_ptr= =E2=80=99 has not been declared VEC (char_ptr) *features =3D NULL; ^ ../../../binutils-gdb/gdb/gdbserver/tdesc.h:57:16: error: ISO C++ forbids d= eclaration of =E2=80=98VEC=E2=80=99 with no type [-fpermissive] VEC (char_ptr) *features =3D NULL; ^ ../../../binutils-gdb/gdb/gdbserver/tdesc.h:57:16: error: expected =E2=80= =98;=E2=80=99 at end of member declaration ../../../binutils-gdb/gdb/gdbserver/tdesc.h: In destructor =E2=80=98target_= desc::~target_desc()=E2=80=99: ../../../binutils-gdb/gdb/gdbserver/tdesc.h:82:30: error: =E2=80=98char_ptr= =E2=80=99 was not declared in this scope for (i =3D 0; VEC_iterate (char_ptr, features, i, f); i++) ^ ../../../binutils-gdb/gdb/gdbserver/tdesc.h:82:54: error: =E2=80=98VEC_iter= ate=E2=80=99 was not declared in this scope for (i =3D 0; VEC_iterate (char_ptr, features, i, f); i++) ^ ../../../binutils-gdb/gdb/gdbserver/tdesc.h:84:15: error: =E2=80=98char_ptr= =E2=80=99 was not declared in this scope VEC_free (char_ptr, features); ^ ../../../binutils-gdb/gdb/gdbserver/tdesc.h:84:33: error: =E2=80=98VEC_free= =E2=80=99 was not declared in this scope VEC_free (char_ptr, features); ^ make[4]: *** [arch/aarch64.o] Error 1 --=20 Yao (=E9=BD=90=E5=B0=A7)