From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122344 invoked by alias); 6 Feb 2018 16:28:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122329 invoked by uid 89); 6 Feb 2018 16:28:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=*h, H*i:sk:5998409, H*f:sk:5998409, H*r:sk:static. X-HELO: mail-wm0-f53.google.com Received: from mail-wm0-f53.google.com (HELO mail-wm0-f53.google.com) (74.125.82.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Feb 2018 16:28:19 +0000 Received: by mail-wm0-f53.google.com with SMTP id f71so4903721wmf.0 for ; Tue, 06 Feb 2018 08:28:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=44Fd2QgTWtmzAdW9Rx5v8to+DF79MEcuAGk0Qqbbv7Q=; b=ip1A9BMbXdQ9Z6ecdlHDdKa6GoShERUEwQcDn3CeBH4EDIkKRLyUx1PYGOCGUjWRy9 0VLWgIWIGl32eYVeDPSHymtltpK0YO5ty4C1trifB/dMSXFnmeqkW+/UdWNiWQn2Or3f 7+V5hRcBLo4MuyoL/0QMeuaiXPeCXv6wRf3O/oLezqtjDTOfVnMi8+BsQbKxK7/xGzNx 7iX5PYU666dbZNF4xm2weVFe9B9C4VcRcwylQNNFg8EQGLZuDgRLwErtJ/a5i6NYSroJ M2gbecSq/xRxb3sWSw9YU/tTaaRmGQ8X4FkDPytPMqPQeQ38nAjbz0nHG5zqosJJ2njo CY5Q== X-Gm-Message-State: APf1xPAON9Vva29/hZXT8WQ2AK2zBW3iIyZsLBXN4JJsOKedjRtjqCcQ ixA4L6ThnzGRDYezuVezPSmqrA== X-Google-Smtp-Source: AH8x2279gtECzFnCVRrmxq5bUoXdTW0DCuDqi/9VWlGqE/w36cCdzY+AsZ3ClbU5YSRTvHFijhnL2Q== X-Received: by 10.28.65.133 with SMTP id o127mr2257627wma.130.1517934497371; Tue, 06 Feb 2018 08:28:17 -0800 (PST) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id 56sm6106173wrt.23.2018.02.06.08.28.16 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 06 Feb 2018 08:28:16 -0800 (PST) From: Yao Qi To: Alan Hayward Cc: Philipp Rudo , "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH] Move arch/tdesc.h to common/common-tdesc.h References: <97948063-b3db-fd3a-f62e-b552935cb8dd@arm.com> <20180201121443.43322674@ThinkPad> <59984094-96C1-4D84-89F6-384769471005@arm.com> Date: Tue, 06 Feb 2018 16:28:00 -0000 In-Reply-To: <59984094-96C1-4D84-89F6-384769471005@arm.com> (Alan Hayward's message of "Thu, 1 Feb 2018 13:19:47 +0000") Message-ID: <86k1vqjd5s.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00085.txt.bz2 Alan Hayward writes: > That results in common/tdesc.h and gdbserver/tdesc.h > That=E2=80=99s not a problem by itself, because we can just prefix the dir > name as part of the include. > I don't see how does the name of *.c file affect the name of *.h file. We can still use common/tdesc.h no matter what the *.c name is. > My next set of patches will then add common/tdesc.c. > This is slightly more tricky because we now build two tdesc.o files. I am inclined to create common/ directory in gdb and gdbserver build tree, and put the object files in the right directory. > The gdbserver IPA rules will need tweaking, and I=E2=80=99m not sure the = OBS > list will work as it is (given it doesn=E2=80=99t have any dir names). > > Like you, I wasn=E2=80=99t sure if there was a naming convention for comm= on/. > In the end I went with the easiest solution :) --=20 Yao (=E9=BD=90=E5=B0=A7)