From: Yao Qi <qiyaoltc@gmail.com>
To: "Marcin Kościelnicki" <koriakin@0x04.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb.trace: Fix unavailable.exp if last register happens to be PC.
Date: Mon, 22 Feb 2016 17:37:00 -0000 [thread overview]
Message-ID: <86io1gd4tg.fsf@gmail.com> (raw)
In-Reply-To: <1456126517-23020-1-git-send-email-koriakin@0x04.net> ("Marcin \=\?utf-8\?Q\?Ko\=C5\=9Bcielnicki\=22's\?\= message of "Mon, 22 Feb 2016 08:35:17 +0100")
Marcin Kościelnicki <koriakin@0x04.net> writes:
> unavailable.exp executes "info registers", expecting to find at least
> two instances of "<unavailable>". However, it uses
> "<unavailable>.*<unavailable>" as the pattern, which doesn't match
> when the last register happens to be available (eg. PC). Change it
> to ".*<unavailable>.*<unavailable>.*" instead.
>
> Noticed on s390, no regression on x86_64.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.trace/unavailable.exp (gdb_unavailable_registers_test_1): Fix
> info registers pattern.
Patch looks good to me.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-02-22 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 7:35 Marcin Kościelnicki
2016-02-22 17:37 ` Yao Qi [this message]
2016-02-22 17:57 ` Marcin Kościelnicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86io1gd4tg.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=koriakin@0x04.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox