From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97813 invoked by alias); 22 Feb 2016 17:37:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97754 invoked by uid 89); 22 Feb 2016 17:37:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Noticed, UD:unavailable.exp, unavailable.exp, unavailableexp X-HELO: mail-pa0-f53.google.com Received: from mail-pa0-f53.google.com (HELO mail-pa0-f53.google.com) (209.85.220.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 22 Feb 2016 17:37:40 +0000 Received: by mail-pa0-f53.google.com with SMTP id ho8so96933282pac.2 for ; Mon, 22 Feb 2016 09:37:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=8CnL+m4zDPm89CCUn2Q7/tMvJUritNxvY0kOR0CzPr0=; b=f0sJ6Mcu/lBNf+eevXNfhdvfSjw+VgmrAmnsVAZjGa7Q9kASPjuprdYWagRzstvJbX f8eWC0Xz7UUaJI0WFiS3N6IdlD/OZyfNpWfydB0UhD76cnoyNdTZ/0xdTA2npE+Zowyz XHH/BO8kxRYpcIuW1w1jWViEpcSfNPVrqIACgPlCUAI8UHnLacKqFsYxVuttdaazvUHT rbBa3sfkSNjcI7I8CEH0PjDYAhLwfyHHcBHNPDTjUovlAYs8/EDm/ywWz6xgKJzfwr4+ J8osHbpilRIz0FIE++OqFJIfVg7jFD2qwbS0orlFRTahZKF2sk5WvjcfEY4zfziZi0Gv ksTA== X-Gm-Message-State: AG10YOS9DNbWz6jzpZ6M8RDi0yX/FhpIwPM99345/bFAkGjUwNij9sSxp81fQjMLLXigAQ== X-Received: by 10.66.147.164 with SMTP id tl4mr38971112pab.40.1456162658140; Mon, 22 Feb 2016 09:37:38 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id xu1sm38475510pab.31.2016.02.22.09.37.36 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 22 Feb 2016 09:37:37 -0800 (PST) From: Yao Qi To: Marcin =?utf-8?Q?Ko=C5=9Bcielnicki?= Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb.trace: Fix unavailable.exp if last register happens to be PC. References: <1456126517-23020-1-git-send-email-koriakin@0x04.net> Date: Mon, 22 Feb 2016 17:37:00 -0000 In-Reply-To: <1456126517-23020-1-git-send-email-koriakin@0x04.net> ("Marcin \=\?utf-8\?Q\?Ko\=C5\=9Bcielnicki\=22's\?\= message of "Mon, 22 Feb 2016 08:35:17 +0100") Message-ID: <86io1gd4tg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00664.txt.bz2 Marcin Ko=C5=9Bcielnicki writes: > unavailable.exp executes "info registers", expecting to find at least > two instances of "". However, it uses > ".*" as the pattern, which doesn't match > when the last register happens to be available (eg. PC). Change it > to ".*.*.*" instead. > > Noticed on s390, no regression on x86_64. > > gdb/testsuite/ChangeLog: > > * gdb.trace/unavailable.exp (gdb_unavailable_registers_test_1): Fix > info registers pattern. Patch looks good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)