From: "Marcin Kościelnicki" <koriakin@0x04.net>
To: gdb-patches@sourceware.org
Cc: "Marcin Kościelnicki" <koriakin@0x04.net>
Subject: [PATCH] gdb.trace: Fix unavailable.exp if last register happens to be PC.
Date: Mon, 22 Feb 2016 07:35:00 -0000 [thread overview]
Message-ID: <1456126517-23020-1-git-send-email-koriakin@0x04.net> (raw)
unavailable.exp executes "info registers", expecting to find at least
two instances of "<unavailable>". However, it uses
"<unavailable>.*<unavailable>" as the pattern, which doesn't match
when the last register happens to be available (eg. PC). Change it
to ".*<unavailable>.*<unavailable>.*" instead.
Noticed on s390, no regression on x86_64.
gdb/testsuite/ChangeLog:
* gdb.trace/unavailable.exp (gdb_unavailable_registers_test_1): Fix
info registers pattern.
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.trace/unavailable.exp | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 5676cac..8acc5c5 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2016-02-22 Marcin KoÅcielnicki <koriakin@0x04.net>
+
+ * gdb.trace/unavailable.exp (gdb_unavailable_registers_test_1): Fix
+ info registers pattern.
+
2016-02-18 Iain Buclaw <ibuclaw@gdcproject.org>
* lib/future.exp: Add D support.
diff --git a/gdb/testsuite/gdb.trace/unavailable.exp b/gdb/testsuite/gdb.trace/unavailable.exp
index e257c2e..343ac64 100644
--- a/gdb/testsuite/gdb.trace/unavailable.exp
+++ b/gdb/testsuite/gdb.trace/unavailable.exp
@@ -330,7 +330,7 @@ proc gdb_unavailable_registers_test_1 { } {
test_register "\$pc"
gdb_test "info registers" \
- "<unavailable>.*<unavailable>" \
+ ".*<unavailable>.*<unavailable>.*" \
"info registers, multiple registers not available"
gdb_test "info registers \$$spreg" \
--
2.7.1
next reply other threads:[~2016-02-22 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 7:35 Marcin Kościelnicki [this message]
2016-02-22 17:37 ` Yao Qi
2016-02-22 17:57 ` Marcin Kościelnicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456126517-23020-1-git-send-email-koriakin@0x04.net \
--to=koriakin@0x04.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox