From: Yao Qi <qiyaoltc@gmail.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
Subject: Re: [PATCH 5/11] Add M32R_MAX_REGISTER_SIZE
Date: Tue, 11 Apr 2017 09:02:00 -0000 [thread overview]
Message-ID: <86inmbwc3v.fsf@gmail.com> (raw)
In-Reply-To: <15D6C0CC-388D-4C9D-AC2F-5A924908D09F@arm.com> (Alan Hayward's message of "Tue, 4 Apr 2017 10:13:37 +0000")
Alan Hayward <Alan.Hayward@arm.com> writes:
> +/* Big enough to hold the size of the largest register in bytes. */
> +#define M32R_MAX_REGISTER_SIZE 4
> +
> #endif /* m32r-tdep.h */
> diff --git a/gdb/m32r-tdep.c b/gdb/m32r-tdep.c
> index 40f29d343b91f254cce2dd783553795c9c990eff..cb53a352b2d47068ad7cd5dacd3325d66bd77964 100644
> --- a/gdb/m32r-tdep.c
> +++ b/gdb/m32r-tdep.c
> @@ -677,7 +677,7 @@ m32r_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
> enum type_code typecode;
> CORE_ADDR regval;
> gdb_byte *val;
> - gdb_byte valbuf[MAX_REGISTER_SIZE];
> + gdb_byte valbuf[M32R_MAX_REGISTER_SIZE];
valbuf is only used for argument registers, r0 - r3. Can you rename
M32R_MAX_REGISTER_SIZE with M32R_ARG_REGISTER_SIZE? and move its
definition into m32r-tdep.c.
/* The size of argument registers (r0 - r3) in bytes. */
#define M32R_ARG_REGISTER_SIZE 4
OK with the change.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-04-11 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 10:13 Alan Hayward
2017-04-11 9:02 ` Yao Qi [this message]
2017-04-12 8:22 ` Alan Hayward
[not found] ` <CAH=s-PP8Pkk7FO6C2EGaBGg8_gLyY8VHJxSfie3rYBx38_ac2g@mail.gmail.com>
2017-04-12 8:54 ` Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86inmbwc3v.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox