From: Alan Hayward <Alan.Hayward@arm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: nd <nd@arm.com>
Subject: [PATCH 5/11] Add M32R_MAX_REGISTER_SIZE
Date: Tue, 04 Apr 2017 10:13:00 -0000 [thread overview]
Message-ID: <15D6C0CC-388D-4C9D-AC2F-5A924908D09F@arm.com> (raw)
Max size set to 32bits, which I determined using regformats/reg-m32r.dat
Tested on a --enable-targets=all build using make check with board files
unix and native-gdbserver.
I do not have an M32R machine to test on.
Ok to commit?
Alan.
2017-04-04 Alan Hayward <alan.hayward@arm.com>
* m32r-tdep.c (m32r_push_dummy_call): Use M32R_MAX_REGISTER_SIZE.
* m32r-tdep.h (M32R_MAX_REGISTER_SIZE): Add.
diff --git a/gdb/m32r-tdep.h b/gdb/m32r-tdep.h
index 102cccecd200b7c192ade124a2fb9d9c59bdb5dd..037fd8965a7c01bd8c3ec0d1eb4a49a70d4478e6 100644
--- a/gdb/m32r-tdep.h
+++ b/gdb/m32r-tdep.h
@@ -47,4 +47,7 @@ enum m32r_regnum
#define M32R_NUM_REGS 25
+/* Big enough to hold the size of the largest register in bytes. */
+#define M32R_MAX_REGISTER_SIZE 4
+
#endif /* m32r-tdep.h */
diff --git a/gdb/m32r-tdep.c b/gdb/m32r-tdep.c
index 40f29d343b91f254cce2dd783553795c9c990eff..cb53a352b2d47068ad7cd5dacd3325d66bd77964 100644
--- a/gdb/m32r-tdep.c
+++ b/gdb/m32r-tdep.c
@@ -677,7 +677,7 @@ m32r_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
enum type_code typecode;
CORE_ADDR regval;
gdb_byte *val;
- gdb_byte valbuf[MAX_REGISTER_SIZE];
+ gdb_byte valbuf[M32R_MAX_REGISTER_SIZE];
int len;
/* First force sp to a 4-byte alignment. */
next reply other threads:[~2017-04-04 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 10:13 Alan Hayward [this message]
2017-04-11 9:02 ` Yao Qi
2017-04-12 8:22 ` Alan Hayward
[not found] ` <CAH=s-PP8Pkk7FO6C2EGaBGg8_gLyY8VHJxSfie3rYBx38_ac2g@mail.gmail.com>
2017-04-12 8:54 ` Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15D6C0CC-388D-4C9D-AC2F-5A924908D09F@arm.com \
--to=alan.hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox