From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65658 invoked by alias); 11 Apr 2017 09:02:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64970 invoked by uid 89); 11 Apr 2017 09:02:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr0-f193.google.com Received: from mail-wr0-f193.google.com (HELO mail-wr0-f193.google.com) (209.85.128.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Apr 2017 09:02:47 +0000 Received: by mail-wr0-f193.google.com with SMTP id o21so27117318wrb.3 for ; Tue, 11 Apr 2017 02:02:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=3IEPuIib6M1mwKpSEn+ukYFu3xGEhrOrYv0dwlX9HCc=; b=LlbfGEgympOOQq7BiGy/Jgx8dSE5ORIgdvLU/PsXbn++7S1oGt1DRAMewoaBx8VqQ0 SgBoJhhidjs7Xewn8pu4U/BHDoqFV1NzoI+uNZi3euM2FZQKSIZhIjR/qwK3Dl5Vp4Hj uMuTUiblZ0MvlF+ymG1ZSNv039kLgANLgEEFT8DjH6RwvGcCFoemZrT98StSy2uX68Wx Zj5bDuM0YF7NjFihkoIU5yVf+/QvwEt1/EmEn6U56qtCCb3IyBVhltn25YZdBIte+f2o XQ3wZpl4DM76zc9Py5onT77xIxjZcjxGsYhefM47nHTmT73dsGt2QLOfZokMPrOh/F2w mf5g== X-Gm-Message-State: AFeK/H0DeHLqG4MaTUnfLAuW3QRM6UwtK34mY5dXagXJPXgRCd2KYsFG56x74jqaaACs6A== X-Received: by 10.223.165.130 with SMTP id g2mr35860734wrc.183.1491901366668; Tue, 11 Apr 2017 02:02:46 -0700 (PDT) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id u66sm1601890wmd.24.2017.04.11.02.02.45 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 11 Apr 2017 02:02:45 -0700 (PDT) From: Yao Qi To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , Subject: Re: [PATCH 5/11] Add M32R_MAX_REGISTER_SIZE References: <15D6C0CC-388D-4C9D-AC2F-5A924908D09F@arm.com> Date: Tue, 11 Apr 2017 09:02:00 -0000 In-Reply-To: <15D6C0CC-388D-4C9D-AC2F-5A924908D09F@arm.com> (Alan Hayward's message of "Tue, 4 Apr 2017 10:13:37 +0000") Message-ID: <86inmbwc3v.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00260.txt.bz2 Alan Hayward writes: > +/* Big enough to hold the size of the largest register in bytes. */ > +#define M32R_MAX_REGISTER_SIZE 4 > + > #endif /* m32r-tdep.h */ > diff --git a/gdb/m32r-tdep.c b/gdb/m32r-tdep.c > index 40f29d343b91f254cce2dd783553795c9c990eff..cb53a352b2d47068ad7cd5dac= d3325d66bd77964 100644 > --- a/gdb/m32r-tdep.c > +++ b/gdb/m32r-tdep.c > @@ -677,7 +677,7 @@ m32r_push_dummy_call (struct gdbarch *gdbarch, struct= value *function, > enum type_code typecode; > CORE_ADDR regval; > gdb_byte *val; > - gdb_byte valbuf[MAX_REGISTER_SIZE]; > + gdb_byte valbuf[M32R_MAX_REGISTER_SIZE]; valbuf is only used for argument registers, r0 - r3. Can you rename M32R_MAX_REGISTER_SIZE with M32R_ARG_REGISTER_SIZE? and move its definition into m32r-tdep.c. /* The size of argument registers (r0 - r3) in bytes. */ #define M32R_ARG_REGISTER_SIZE 4 OK with the change. --=20 Yao (=E9=BD=90=E5=B0=A7)