From: Yao Qi <qiyaoltc@gmail.com>
To: Xavier Roirand <roirand@adacore.com>
Cc: gdb-patches@sourceware.org, brobecker@adacore.com
Subject: Re: [RFA v2] (Ada) Fix frame argument printing when using auto language mode
Date: Fri, 23 Feb 2018 08:55:00 -0000 [thread overview]
Message-ID: <86h8q8hyps.fsf@gmail.com> (raw)
In-Reply-To: <1519374774-13992-1-git-send-email-roirand@adacore.com> (Xavier Roirand's message of "Fri, 23 Feb 2018 09:32:54 +0100")
Xavier Roirand <roirand@adacore.com> writes:
Patch is good to me, some comments below,
> +extern const struct language_defn ada_language_defn;
> +
> static int print_field_values (struct type *, const gdb_byte *,
> int,
> struct ui_file *, int,
> @@ -1208,7 +1210,7 @@ ada_val_print (struct type *type,
> {
> ada_val_print_1 (type, embedded_offset, address,
> stream, recurse, val, options,
> - current_language);
> + &ada_language_defn);
or we can use "language_def (language_ada)", so that we don't need to
declare ada_language_defn above.
> +
> +gdb_test "bt" \
> + "#1 $hex in pck\\.call_me \\(s=\"test\"\\).*" \
> + "backtrace (auto: c)"
Don't use "tail parentheses" on the test message,
https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_parentheses.22_on_test_messages
--
Yao (齐尧)
next prev parent reply other threads:[~2018-02-23 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 8:33 Xavier Roirand
2018-02-23 8:55 ` Yao Qi [this message]
2018-02-23 9:37 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h8q8hyps.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=roirand@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox